Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import file #55

Merged
merged 24 commits into from
Oct 4, 2024
Merged

Import file #55

merged 24 commits into from
Oct 4, 2024

Conversation

Mohammad96Assaf
Copy link
Contributor

@Mohammad96Assaf Mohammad96Assaf commented Sep 25, 2024 •
edited
Loading

ref #46

  • Adjust layout and styling of the file upload section.
  • Implement drag-and-drop functionality.
  • Update the info containers to display server response
  • Display relevant feedback after successful or failed file upload.

@Mohammad96Assaf Mohammad96Assaf added the need-reviewer Send notification in Discord label Sep 25, 2024
choffmann
choffmann requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

package-lock.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
frontend/src/components/general/fileUpload/FileUpload.tsx Outdated Show resolved Hide resolved
frontend/src/routes/_protected/import.tsx Outdated Show resolved Hide resolved
doriengr
doriengr reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@doriengr doriengr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🔥 I left some design feedback and some improvements for semantic html usage.

frontend/src/routes/_protected/settings.tsx Outdated Show resolved Hide resolved
frontend/src/routes/_protected/settings.tsx Outdated Show resolved Hide resolved
frontend/src/routes/_protected/settings.tsx Outdated Show resolved Hide resolved
frontend/src/routes/_protected/settings.tsx Outdated Show resolved Hide resolved
frontend/src/routes/_protected/import.tsx Outdated Show resolved Hide resolved
frontend/src/routes/_protected/import.tsx Outdated Show resolved Hide resolved
frontend/src/components/general/fileUpload/FileUpload.tsx Outdated Show resolved Hide resolved
frontend/src/components/general/fileUpload/FileUpload.tsx Outdated Show resolved Hide resolved
@doriengr
Copy link
Contributor

Next time it would be also nice, if you use conventional commits and name branches after feature/..., fix/... etc.
That would be great 😍

Mohammad Assaf added 10 commits September 25, 2024 15:27
Mohammad96Assaf
Mohammad96Assaf commented Sep 25, 2024
View reviewed changes
Copy link
Contributor Author

@Mohammad96Assaf Mohammad96Assaf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove package-lock.json
  • Improve some stylings
  • Restyle and use DashboardCard instead of SettingsCard
  • Delete InfoCard and use GeneralStatusCard instead
  • Use PrimaryButton in FileUpload component
  • Get updates from the develop branch

@Mohammad96Assaf Mohammad96Assaf mentioned this pull request Sep 26, 2024
Closed
4 tasks
@Mohammad96Assaf Mohammad96Assaf merged commit 2c438e5 into develop Oct 4, 2024
1 check passed
@Mohammad96Assaf Mohammad96Assaf deleted the import_file branch October 4, 2024 19:16
@Mohammad96Assaf Mohammad96Assaf restored the import_file branch October 22, 2024 15:16
@doriengr doriengr deleted the import_file branch October 24, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriengr doriengr doriengr approved these changes

@xk0niR xk0niR Awaiting requested review from xk0niR

@choffmann choffmann Awaiting requested review from choffmann

Assignees
No one assigned
Labels
need-reviewer Send notification in Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mohammad96Assaf @doriengr @choffmann