Feature/add treecluster filter #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 13, 2024 12:46
choffmann
approved these changes
Sep 15, 2024
Comment on lines
+9
to
+10
| status: z.array(z.string()).optional(), | ||
| region: z.array(z.string()).optional(), |
There was a problem hiding this comment.
I have changed this to an array of strings, so you do not need to do this manually.
Comment on lines
+29
to
+37
| const search = useLoaderData({ from: '/_protected/treecluster/' }); | ||
|
|
||
| const [statusTags, setStatusTags] = useState<string[]>(search.status); | ||
| const [regionTags, setRegionTags] = useState<string[]>(search.region); | ||
|
|
||
| useEffect(() => { | ||
| if (search.status) setStatusTags(search.status); | ||
| if (search.region) setRegionTags(search.region); | ||
| }, [search.status, search.region]); |
There was a problem hiding this comment.
And because we have parsed it in the router loader, we can access the data with the useLoaderData hook.
Comment on lines
+17
to
+20
| loaderDeps: ({ search: { status, region } }) => ({ | ||
| status: status || [], | ||
| region: region || [], | ||
| }), |
There was a problem hiding this comment.
So now we can say that if it's not undefined, take the search param as an array, otherwise use an empty array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #26