feat: add treecluster list #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choffmann
approved these changes
Sep 14, 2024
| {clusters.length === 0 ? ( | ||
| <li className="text-center text-dark-600 mt-10"> | ||
| <p> | ||
| Keine Ergebnisse mit den eingestellten Filteroptionen gefunden. |
There was a problem hiding this comment.
What if there is no data, e.g. on first use? Then the user sees this information and may be confused?
Suggestion: Maybe check in the condition if a filter (when the filter logic is back) is active. If so, display this message, otherwise display another message.
| @@ -0,0 +1,14 @@ | |||
| export enum Region { | |||
There was a problem hiding this comment.
Maybe we should move this to the backend. But for now we can leave it here
There was a problem hiding this comment.
I'll add this as a note to the issue 👍
| @@ -0,0 +1,14 @@ | |||
| export enum WateringStatus { | |||
There was a problem hiding this comment.
Same here, we should move this to the backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #26