feat: added searchbar #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zoka-tech the pipeline is failing. Please fix it. |
doriengr
requested changes
Oct 24, 2024
|
|
||
| export default TreeclusterWithProvider | ||
| export default TreeclusterWithProvider; |
There was a problem hiding this comment.
Please use the prettier config out of this repo. We are not using semicolons.
| <StatusFieldset /> | ||
| <RegionFieldset /> | ||
| </Dialog> | ||
| <div className="flex items-center gap-4"> |
There was a problem hiding this comment.
Please do not use so many <div> elements. Let's make sure that we don't create unnecessary HTML elements and also use semantic HTML. That would be great 😍
Maybe we can add the input field into a new component? It should be reusable.
|
Can we make the search bar as long as the filter button like in the design? 🙏 
|
|
It works great 👍 You could also check out this article to make it more accessible and more semantic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.