Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not filter treecluster without region or show them on map #192

Merged
merged 3 commits into from
Oct 17, 2024
Merged

fix: do not filter treecluster without region or show them on map #192

merged 3 commits into from
Oct 17, 2024

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Oct 17, 2024 •
edited
Loading

Close #188

How to test it:

  1. Create a tree cluster that has no trees (even on error the tree cluster is currently created)
  2. Navigate to the map and check that the treecluster is NOT displayed and the map should not crash anymore
  3. Navigate to the index page of all treeclusters and filter them by region. The filter should not crash anymore

@doriengr doriengr added the need-reviewer Send notification in Discord label Oct 17, 2024
@doriengr doriengr self-assigned this Oct 17, 2024
choffmann
choffmann approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@choffmann choffmann merged commit 0cd852e into release/v1.0.0 Oct 17, 2024
@choffmann choffmann deleted the bugfix/treecluster-with-no-trees branch October 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choffmann choffmann choffmann approved these changes

Assignees

@doriengr doriengr

Labels
need-reviewer Send notification in Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doriengr @choffmann