Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create startpage #106

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Feature/create startpage #106

merged 7 commits into from
Oct 7, 2024

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Oct 6, 2024

Close #105

@doriengr doriengr self-assigned this Oct 6, 2024
@doriengr doriengr added the need-reviewer Send notification in Discord label Oct 6, 2024
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🔥 one thing I notice is when you go to the start page when you loggend in, the application things you are not authenticated. But I think this is a different issue and has to do with us not saving the jwt token... Feel free to fix it here or open a new issue

ge_not_show_logged_in

frontend/src/components/layout/ProfileButton.tsx Outdated Show resolved Hide resolved
frontend/src/routes/index.tsx Outdated Show resolved Hide resolved
@doriengr
Copy link
Contributor Author

doriengr commented Oct 6, 2024

@choffmann I created a new issue for that #110

@doriengr doriengr requested a review from choffmann October 6, 2024 17:33
@doriengr doriengr merged commit df35258 into develop Oct 7, 2024
1 check passed
@doriengr doriengr deleted the feature/create-startpage branch October 7, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-reviewer Send notification in Discord
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create startpage that has no access restriction
2 participants