Carbondb unique #877
Merged
Carbondb unique #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eco-CI Output:
🌳 CO2 Data: |
ribalba
reviewed
Sep 25, 2024
|
|
||
| ALTER TABLE IF EXISTS public.carbondb_energy_data_day | ||
| ADD CONSTRAINT unique_machine_project_date UNIQUE (machine, date); | ||
| CREATE UNIQUE INDEX unique_entry ON carbondb_energy_data_day (type, company, machine, project, tags, date) NULLS NOT DISTINCT; |
There was a problem hiding this comment.
Why are you adding eh company and the project? Initially the idea was that you only need a machine. But I think we are going to rework this anyway
ArneTR
added a commit
that referenced
this pull request
Sep 27, 2024
* main: Authentication in GMT (#872) Phase name check (#893) Carbondb unique (#877) Added DiskIO Reporter (#825) Bump pylint from 3.3.0 to 3.3.1 (#913) Bump aiohttp from 3.10.5 to 3.10.6 (#912) Bump plotext from 5.3.1 to 5.3.2 (#914) Bump pandas from 2.2.2 to 2.2.3 (#910) Bump plotext from 5.2.8 to 5.3.1 (#909) Bump pylint from 3.2.7 to 3.3.0 (#911) Bump psycopg-pool from 3.2.2 to 3.2.3 (#901) Bump pydantic from 2.9.1 to 2.9.2 (#904) Bump fastapi[standard] from 0.114.2 to 0.115.0 (#905) Importer for Measurements (#908)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constraint for the uniqueness in CarbonDB was not looking at all relevant rows.
We had this already implemented on our live system but not backported it to the repository.
The implementation so far was however not respecting NULL values correctly. The new unique index now treats two NULL values as identical and will trigger now.
@ribalba Data volume is now down from 13 GB to 9 MB