-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature : generation docker-compose by maven (manual from @dedece35) #9
base: main
Are you sure you want to change the base?
Conversation
…se par maven (version, uniformisation server sonar, absolute url target)
…compose_by_maven # Conflicts: # .gitignore # src/pom.xml
…b.com/Silicoman/ecoCode into feat_generate_docker_compose_by_maven
Hi @Silicoman and @obeone to summarize our discussions and what I understand between your two PRs.
But, there are several problems before merging them :
In conclusion, I think we have to :
Whta do you think about it @Silicoman and @obeone ? |
Thanks to sharing your pov. Due to technical change, i think the simpliest way to solve #9 is to recreate a branch with the little change (adding a plugin and template docker-compose). I will precise tickets/branch to close due to duplication. |
Hi @Silicoman and @obeone, |
HI @Silicoman, |
Hi @dedece35 @Silicoman @obeone , I was just thinking, with the new release system (thx @dedece35) maybe it is possible to provide a better quick start that does not need to build jar. For example if we had a Dockerfile like this one :
And some minor change to the existing docker-compose it could be simple enough for everyone (just need docker and docker-compose). What do you think about it ? I'm still wondering about two things :
Regards, |
Hi, sorry, I was quite busy these days. Yes @MP-Aubay, I think it’s a good idea. If now we have jar files published in release section, it’s possible to include it in Dockerfile directly. To build it, it’s possible to use Github Action to do that, it can be run on new release. To sum up :
(Maybe it’s possible to handle incoming webhook, but I didn’t look for, for now) |
Hi @obeone, @MP-Aubay, @Silicoman, |
Hi @obeone thx. |
Hi ! I just read again the discussion, and I think it's better to use jar's created with as release one (if needed). And for the main subject of this PR, yup, I can work on the docker-compose.yml, but I'll do another PR (because there is too many conflict, and I don't have write access to this repo, so I can't work on this branch) |
This PR has been automatically marked as stale because it has no activity for 30 days. |
initial PR (before migration): cnumr/ecoCode#89
(plop @Silicoman )