Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade some versions + sonar version from 9.3 to 9.8 #15

Merged
merged 15 commits into from
Dec 25, 2022

Conversation

oussamaLaribi
Copy link
Contributor

No description provided.

@oussamaLaribi oussamaLaribi changed the title Upgrade some versions + sonar version from 9.4 to 9.7 Upgrade some versions + sonar version from 9.3 to 9.7 Dec 14, 2022
@dedece35
Copy link
Member

dedece35 commented Dec 14, 2022

Hi @oussamaLaribi,
i've just made a review with some questions. please see them.
another question / note :

  • do you run tests locally ? unit tests and manual tests with integration of plugin in a old SonarQube like a 9.3 version ? (to verify compatibility)
  • I've just corrected a mistake in build github worklfow on main branch (during repository migration, I disabled build&analyse phase because of sonarQube secrets not ready) : I've just enabled again a build&test phase in build github workflow, I relaunch the worklow for your branch to check my correction with your branch, but your banch is not up-to-date ... could you upgrade your branch and commit again something to run the workflow automatically please ?
  • next step will be to report this sonarQube upgrade to ecocode-mobile, please

@oussamaLaribi
Copy link
Contributor Author

Hi @oussamaLaribi, i've just made a review with some questions. please see them. another question / note :

  • do you run tests locally ? unit tests and manual tests with integration of plugin in a old SonarQube like a 9.3 version ? (to verify compatibility)
  • I've just corrected a mistake in build github worklfow on main branch (during repository migration, I disabled build&analyse phase because of sonarQube secrets not ready) : I've just enabled again a build&test phase in build github workflow, I relaunch the worklow for your branch to check my correction with your branch, but your banch is not up-to-date ... could you upgrade your branch and commit again something to run the workflow automatically please ?
  • next step will be to report this sonarQube upgrade to ecocode-mobile, please

Hi @dedece35, thanks for the review.
Yes, I did those local tests.
I upgraded my branch also. It's up to date now.
Next, I will report this sonarQube upgrade to ecocode-mobile.

@dedece35
Copy link
Member

@oussamaLaribi ok for new workflow with build&test phase.
but you don't take into account my 3 pending review comments 😜 : please see above.

@oussamaLaribi
Copy link
Contributor Author

oussamaLaribi commented Dec 14, 2022

@oussamaLaribi ok for new workflow with build&test phase. but you don't take into account my 3 pending review comments 😜 : please see above.

@dedece35 I can't find these pending review comments.
Also for the integration of the plugin in an old SonarQube, it requires at least SonarQube 9.4

pom.xml Outdated Show resolved Hide resolved
python-plugin/pom.xml Outdated Show resolved Hide resolved
@dedece35
Copy link
Member

@oussamaLaribi, sorry, my bad, I forget to submit my review :p : done.
now, if SonarQube 9.4 is required, I think you have to mention it in installation documentation.

@oussamaLaribi
Copy link
Contributor Author

@oussamaLaribi, sorry, my bad, I forget to submit my review :p : done. now, if SonarQube 9.4 is required, I think you have to mention it in installation documentation.

@dedece35 Okay, I'll mention it. Thanks

@dedece35 dedece35 added 🚀 enhancement New feature or request dependencies Pull requests that update a dependency file php java python labels Dec 14, 2022
dedece35
dedece35 previously approved these changes Dec 15, 2022
@dedece35
Copy link
Member

Hi @oussamaLaribi ,
I made few minutes ago a refactoring / optimization on pom.xml files : there were some mistakes on scopes on dependencies.
Please, update your branch with my modifications. I think you will have some conflicts, be carefull.

Then you can delete "compile" because it is the default scope on your dependency sonar-plugin-api-impl

@oussamaLaribi
Copy link
Contributor Author

Hi @oussamaLaribi , I made few minutes ago a refactoring / optimization on pom.xml files : there were some mistakes on scopes on dependencies. Please, update your branch with my modifications. I think you will have some conflicts, be carefull.

Then you can delete "compile" because it is the default scope on your dependency sonar-plugin-api-impl

Hi @dedece35, Okay I'll do it. Thanks.

@dedece35
Copy link
Member

@oussamaLaribi, I can help if you need. tell me if you want some help.

@oussamaLaribi
Copy link
Contributor Author

@oussamaLaribi, I can help if you need. tell me if you want some help.

Hi @dedece35, There's something wrong with the python plugin. After the update, it builds with the previous version and compiles with the new version. I am looking for a way to solve it.

@dedece35
Copy link
Member

hi @oussamaLaribi , do you want to say java plugin instead ? because there is compilation failure on java plugin class.
tell me if you want some help.

@oussamaLaribi
Copy link
Contributor Author

hi @oussamaLaribi , do you want to say java plugin instead ? because there is compilation failure on java plugin class. tell me if you want some help.

Hi @dedece35, you can check now the compilation failure on the python plugin class.

@dedece35
Copy link
Member

dedece35 commented Dec 16, 2022

@oussamaLaribi
I made the correction of the problem : several problems on pom.xml files
I made a temporary PR #20 for you to check my modifications : please take into account all modifications on all pom.xml files : check commit 565dd48
Problem was mainly in versions of python / php plugins.
I checked locally :

  • compilation
  • package building
  • deploy and execution of JAR plugins on a dockerized SonarQube

@oussamaLaribi
Copy link
Contributor Author

@oussamaLaribi I made the correction of the problem : several problems on pom.xml files I made a temporary PR #20 for you to check my modifications : please take into account all modifications on all pom.xml files : check commit 565dd48 Problem was mainly in versions of python / php plugins. I checked locally :

  • compilation
  • package building
  • deploy and execution of JAR plugins on a dockerized SonarQube

Hi @dedece35, Okay I'll check it. Thanks.

@dedece35 dedece35 self-requested a review December 21, 2022 23:03
@dedece35 dedece35 dismissed their stale review December 21, 2022 23:04

I d'ont know if you finushed to apply my #20 PR modifications

@dedece35
Copy link
Member

Hi @oussamaLaribi
is it all ok for you thus I can do again a complete review ?

@oussamaLaribi
Copy link
Contributor Author

oussamaLaribi commented Dec 22, 2022

Hi @oussamaLaribi is it all ok for you thus I can do again a complete review ?

Hi @dedece35 Yes, just the commented code "requirePlugins" . I can't find another way to force it, in the official doc there is nothing.

INSTALL.md Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
python-plugin/pom.xml Outdated Show resolved Hide resolved
python-plugin/pom.xml Show resolved Hide resolved
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oussamaLaribi , i've just made a new review. I put here some new comments.
cheers, it's almost done :p

@oussamaLaribi
Copy link
Contributor Author

new review

Hi @dedece35, it's done. Thanks.

@oussamaLaribi oussamaLaribi changed the title Upgrade some versions + sonar version from 9.3 to 9.7 Upgrade some versions + sonar version from 9.3 to 9.8 Dec 23, 2022
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check again and test again localy with all your last modifications.
It's now ok : you can merge your branch.

Another thing with minor priority, there is WARNINGs during build process in the console (tool_build.sh file execution).
After SonarQube has been started, plugins are ok regarding logs, but I think we have to find a solution to correct those Warnings during build phase. This problem is due to maven-shade-plugin added. Check capture above :
Capture d’écran 2022-12-23 à 22 08 49

@dedece35 dedece35 merged commit 8bdcc4a into green-code-initiative:main Dec 25, 2022
@dedece35
Copy link
Member

dedece35 commented Dec 25, 2022

Hi @oussamaLaribi, I've just merged your PR and checked in main branch again (all is ok).
Please report all last modifications to ecocode-mobile repository and make me reviewer

@oussamaLaribi
Copy link
Contributor Author

Hi @oussamaLaribi, I've just merged your PR and checked in main branch again (all is ok). Please report all last modifications to ecocode-mobile repository and make me reviewer
Hi @dedece35, Okay I'll do it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java php python 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants