[MAINTENANCE] Add docstrings and type hints to Anonymizer
#4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_expectations into maintenance/great-617/refactor-is_parent_class_recognized-helper-in-anonymizer
…_expectations into maintenance/great-617/refactor-is_parent_class_recognized-helper-in-anonymizer
…_expectations into maintenance/great-617/refactor-is_parent_class_recognized-helper-in-anonymizer
…class_recognized-helper-in-anonymizer
…_expectations into maintenance/great-617/refactor-is_parent_class_recognized-helper-in-anonymizer
…_expectations into maintenance/great-617/refactor-is_parent_class_recognized-helper-in-anonymizer
…_expectations into maintenance/great-617/refactor-is_parent_class_recognized-helper-in-anonymizer
|
✔️ Deploy Preview for niobium-lead-7998 ready! 🔨 Explore the source changes: e1082b5 🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/6230d4e1529d1d000ac349a3 😎 Browse the preview: https://deploy-preview-4419--niobium-lead-7998.netlify.app |
…_expectations into maintenance/great-617/refactor-is_parent_class_recognized-helper-in-anonymizer
…class_recognized-helper-in-anonymizer
Shinnnyshinshin
approved these changes
Mar 15, 2022
Comment on lines
+94
to
+97
| @property | ||
| def anonymizer(self) -> Anonymizer: | ||
| return self._anonymizer | ||
|
|
Comment on lines
+52
to
+64
| """Obsfuscates a given string using an MD5 hash. | ||
|
|
||
| Utilized to anonymize user-specific/sensitive strings in usage statistics payloads. | ||
|
|
||
| Args: | ||
| string_ (Optional[str]): The input string to anonymize. | ||
|
|
||
| Returns: | ||
| The MD5 hash of the input string. If an input of None is provided, the string is untouched. | ||
|
|
||
| Raises: | ||
| TypeError if input string does not adhere to type signature Optional[str]. | ||
| """ |
cdkini
deleted the
maintenance/great-617/refactor-is_parent_class_recognized-helper-in-anonymizer
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Mar 15, 2022
…hub.com/great-expectations/great_expectations into feature/GREAT-500/add-notebooks-for-rbp * 'feature/GREAT-500/add-notebooks-for-rbp' of https://github.com/great-expectations/great_expectations: [FEATURE] Use more granular requirements-dev-xxx.txt files (#4327) standardise on include and exclude columns list for profiler (#4424) [MAINTENANCE] Continue chipping away at warnings (#4422) [MAINTENANCE] Add docstrings and type hints to `Anonymizer` (#4419) Replace "sampling_method" with "estimator", since the latter is a more fitting name for the parameter. (#4420) [BUGFIX] Adding `--spark` flag back to `azure-pipelines.yml` compatibility_matrix stage. (#4418) [MAINTENANCE] Refactor out unnecessary Anonymizer child classes (#4408) [BUGFIX] Pin `pytest-azurepipelines` due to breaking changes made in latest release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Definition of Done
Please delete options that are not relevant.