[BUGFIX] Adding --spark flag back to azure-pipelines.yml compatibility_matrix stage.
#4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for niobium-lead-7998 ready! 🔨 Explore the source changes: 44dc4bd 🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/6230c49f14fa05000a547889 😎 Browse the preview: https://deploy-preview-4418--niobium-lead-7998.netlify.app |
Shinnnyshinshin
requested review from
cdkini,
alexsherstinsky,
anthonyburdi,
donaldheppner and
NathanFarmer
cdkini
suggested changes
Mar 15, 2022
azure-pipelines.yml
Outdated
| @@ -89,7 +89,7 @@ stages: | |||
| - job: compatibility_matrix | |||
| condition: or(eq(variables.isScheduled, true), eq(variables.isMain, true)) | |||
| variables: | |||
| GE_pytest_opts: '--no-sqlalchemy' | |||
| GE_pytest_opts: '--no-sqlalchemy --spark' | |||
There was a problem hiding this comment.
This should be --no-spark right?
There was a problem hiding this comment.
Changes requested just to block auto merge - let's confirm which flags are needed for which steps.
cdkini
approved these changes
Mar 15, 2022
Shinnnyshinshin
deleted the
bugfix/adding-spark-back-to-compability-matrix
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Mar 15, 2022
…hub.com/great-expectations/great_expectations into feature/GREAT-500/add-notebooks-for-rbp * 'feature/GREAT-500/add-notebooks-for-rbp' of https://github.com/great-expectations/great_expectations: [FEATURE] Use more granular requirements-dev-xxx.txt files (#4327) standardise on include and exclude columns list for profiler (#4424) [MAINTENANCE] Continue chipping away at warnings (#4422) [MAINTENANCE] Add docstrings and type hints to `Anonymizer` (#4419) Replace "sampling_method" with "estimator", since the latter is a more fitting name for the parameter. (#4420) [BUGFIX] Adding `--spark` flag back to `azure-pipelines.yml` compatibility_matrix stage. (#4418) [MAINTENANCE] Refactor out unnecessary Anonymizer child classes (#4408) [BUGFIX] Pin `pytest-azurepipelines` due to breaking changes made in latest release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
--no-postgresqland--no-sparkflags frompytest. Enable--postgresqland--spark#4309--sparkflag back tocompatibility_matrix stage of mainazure-pipelines.yml`