Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Enhance data doc to show data asset name in overview block #1952

Merged
merged 5 commits into from
Oct 5, 2020
Merged

[ENHANCEMENT] Enhance data doc to show data asset name in overview block #1952

merged 5 commits into from
Oct 5, 2020

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Oct 2, 2020 •
edited
Loading

Description:

  • To add data asset name in the "Overview" block, previously only available when click "show more info"
    image

Related issue #1804

@noklam
Copy link
Contributor Author

noklam commented Oct 2, 2020

@ge-cla-bot check

@noklam
Copy link
Contributor Author

noklam commented Oct 2, 2020

@cla-bot check

@noklam noklam changed the title [ENHANCEMENT] Enhance data doc to show data asset name in overview block #1804 [ENHANCEMENT] Enhance data doc to show data asset name in overview block Oct 2, 2020
eugmandel
eugmandel approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@eugmandel eugmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noklam Thank you for making this change! Displaying the data asset above the fold is much more helpful.

@eugmandel eugmandel merged commit 7f95536 into great-expectations:develop Oct 5, 2020
@noklam
Copy link
Contributor Author

noklam commented Oct 6, 2020

great. :)

@noklam
Copy link
Contributor Author

noklam commented Oct 11, 2020

@eugmandel I am participating in hacktoberfest. Could you add a #hacktoberfest-accepted label to this PR?

alexsherstinsky pushed a commit to alexsherstinsky/great_expectations that referenced this pull request Feb 19, 2021
[ENHANCEMENT] Enhance data doc to show data asset name in overview bl…
c02ba5d 
…ock (great-expectations#1952)

* enhance data doc to show data asset name in overview block great-expectations#1804

* Update test, only get data_asset_name if exist

* Update fixture to match the new template

* update fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugmandel eugmandel eugmandel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noklam @eugmandel