Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancement: Make data asset name more visible in Data Docs #1804

Closed
spbail opened this issue Aug 14, 2020 · 3 comments
Closed

Minor enhancement: Make data asset name more visible in Data Docs #1804

spbail opened this issue Aug 14, 2020 · 3 comments
Assignees
Labels
enhancement feature:data_docs Issues and PR related to Data Docs good first issue Good issues for new contributors. Join #contributors-contributing in our Slack for help! stale Stale issues and PRs

Comments

@spbail
Copy link
Contributor

spbail commented Aug 14, 2020

Is your feature request related to a problem? Please describe.
Currently, the data asset name on the Data Docs validation results page is tucked away behind the "Show more info" link, which makes it difficult to see what the validation results are for.

Describe the solution you'd like
I would like the data asset name to show up in the grey header bar at the top of the validation results page as shown in the attached mockup, rather than in the "Show more info" section.

Describe alternatives you've considered
None.

Screen Shot 2020-07-23 at 11 49 58 AM

@spbail spbail added enhancement good first issue Good issues for new contributors. Join #contributors-contributing in our Slack for help! labels Aug 14, 2020
@spbail spbail changed the title Minor improvement: Make data asset name more visible in Data Docs Minor enhancement: Make data asset name more visible in Data Docs Aug 14, 2020
@haydarai
Copy link
Contributor

haydarai commented Oct 1, 2020

The issue looks related to #1805. If it's okay for me to take the first one, can I also take this one?

@spbail
Copy link
Contributor Author

spbail commented Oct 1, 2020

@haydarai It's somewhat related, but in this case, the data asset name is already in the docs, it's just a little further down the page (hidden behind "Show more info"). So this fix should be super easy.

See https://docs.greatexpectations.io/en/latest/contributing.html for step-by-step guidance on contributions. As I mentioned on the other issue, make sure the tests still pass since we have tests on a lot of outputs.

Thank you!

@spbail spbail self-assigned this Oct 1, 2020
@spbail spbail added the feature:data_docs Issues and PR related to Data Docs label Oct 1, 2020
eugmandel pushed a commit that referenced this issue Oct 5, 2020
…ock (#1952)

* enhance data doc to show data asset name in overview block #1804

* Update test, only get data_asset_name if exist

* Update fixture to match the new template

* update fixture
alexsherstinsky pushed a commit to alexsherstinsky/great_expectations that referenced this issue Feb 19, 2021
…ock (great-expectations#1952)

* enhance data doc to show data asset name in overview block great-expectations#1804

* Update test, only get data_asset_name if exist

* Update fixture to match the new template

* update fixture
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?\n\nThis issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale issues and PRs label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature:data_docs Issues and PR related to Data Docs good first issue Good issues for new contributors. Join #contributors-contributing in our Slack for help! stale Stale issues and PRs
Projects
None yet
Development

No branches or pull requests

2 participants