Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request support phpunit6 #9

Closed
fizzka opened this issue Jun 30, 2017 · 2 comments
Closed

request support phpunit6 #9

fizzka opened this issue Jun 30, 2017 · 2 comments

Comments

@fizzka
Copy link

fizzka commented Jun 30, 2017 •
edited
Loading

now:

$ composer require -q --dev graze/hamcrest-test-listener && composer outdated -o | grep 'phpunit/phpunit '
phpunit/phpunit 5.7.21 ~ 6.2.3 The PHP Unit Testing framework.
@ascii-soup
Copy link
Contributor

Any objections to me creating a PR for this?

It's a breaking change since in PHPUnit 6 the Framework classes now use namespaces so I guess a bump to 3.0 would be needed. Could possibly attempt to address #10 within the same version bump too, but not sure how possible it is to fix that issue.

ascii-soup pushed a commit to ascii-soup/hamcrest-test-listener that referenced this issue Jul 25, 2017
@luxtonn
⬆️ Update phpunit/phpunit dependency to support ^6.0
88a0892 
Addresses graze#9
ascii-soup pushed a commit to ascii-soup/hamcrest-test-listener that referenced this issue Jul 25, 2017
@luxtonn
⬆️ TestListener compatible with PHPUnit 6
60f28a1 
Addresses graze#9
@ascii-soup ascii-soup mentioned this issue Jul 25, 2017
Merged
ascii-soup pushed a commit to ascii-soup/hamcrest-test-listener that referenced this issue Jul 25, 2017
@luxtonn
⬆️ Update phpunit/phpunit dependency to support ^6.0
27b6346 
Addresses graze#9
ascii-soup pushed a commit to ascii-soup/hamcrest-test-listener that referenced this issue Jul 25, 2017
@luxtonn
⬆️ TestListener compatible with PHPUnit 6
dccaa11 
Addresses graze#9
ascii-soup pushed a commit to ascii-soup/hamcrest-test-listener that referenced this issue Jul 26, 2017
@luxtonn
⬆️ Update phpunit/phpunit dependency to support ^6.0
b0f3ace 
Addresses graze#9
ascii-soup pushed a commit to ascii-soup/hamcrest-test-listener that referenced this issue Jul 26, 2017
@luxtonn
⬆️ TestListener compatible with PHPUnit 6
a88ea60 
Addresses graze#9
sjparkinson pushed a commit that referenced this issue Jul 27, 2017
@ascii-soup @sjparkinson
PHPUnit 6 compatibility (#11)
3356cd0 
* ⬆️ Update phpunit/phpunit dependency to support `^6.0`

Addresses #9

* ⬆️ Update travis.yml to remove PHP 5.x and HHVM

* ⬆️ TestListener compatible with PHPUnit 6

Addresses #9

* 📝 Update README
@sjparkinson
Copy link
Contributor

Closed thanks to #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sjparkinson @ascii-soup @fizzka