Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listener isn't friendly with phpunit "risky tests" #10

Closed
fizzka opened this issue Jul 6, 2017 · 4 comments
Closed

listener isn't friendly with phpunit "risky tests" #10

fizzka opened this issue Jul 6, 2017 · 4 comments

Comments

@fizzka
Copy link

fizzka commented Jul 6, 2017

if I run phpunit --report-useless-tests on tests with hamcrest assertions i've got R (risky test)

@fizzka
Copy link
Author

fizzka commented Jul 25, 2017

this issue appears in phpunit5 too

@ascii-soup
Copy link
Contributor

It seems that PHPUnit is reporting the risky test before the 'endTest()' method on the listener is called (which is where this library is adding to the assertion count) - this might need some discussion over at PHPUnit - will feed back when I know more.

@fizzka
Copy link
Author

fizzka commented Jul 25, 2017 via email

@sjparkinson
Copy link
Contributor

Closed from the response in sebastianbergmann/phpunit#2744.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants