-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
listener isn't friendly with phpunit "risky tests" #10
Comments
Closed
this issue appears in phpunit5 too |
Merged
It seems that PHPUnit is reporting the risky test before the 'endTest()' method on the listener is called (which is where this library is adding to the assertion count) - this might need some discussion over at PHPUnit - will feed back when I know more. |
that' correct. thanks)
2017-07-25 16:54 GMT+03:00 ASCII Soup <[email protected]>:
… It seems that PHPUnit is reporting the risky test before the 'endTest()'
method on the listener is called (which is where this library is adding to
the assertion count) - this might need some discussion over at PHPUnit -
will feed back when I know more.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACRjYIycCLw6s45CMP-Le6kJS3sB9MqMks5sRfOGgaJpZM4OPcV1>
.
|
Closed from the response in sebastianbergmann/phpunit#2744. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
if I run phpunit --report-useless-tests on tests with hamcrest assertions i've got R (risky test)
The text was updated successfully, but these errors were encountered: