Render the name of islets

[sommerluk]

This fixes #159

[matthijsmelissen]

I think this would also benefit from an approach based on way_pixels, see for example #941.

[HolgerJeromin]

If i checked right, the project.yaml was not updated...

[pnorman]

Please see https://github.com/gravitystorm/openstreetmap-carto/blob/master/CONTRIBUTING.md#editing-layers and rebase this PR

[sommerluk]

@HolgerJeromin @pnorman Thanks for the hint. I even wasn't aware that project.yaml exists.

@math1985 I've played a little bit with way_pixels, adopting the values that you have used in #941 also for islands and islets in amenity-points.mss

.text {
  [feature = 'place_island'][zoom >= 7][way_pixels > 3000],
  [feature = 'place_island'][zoom >= 14],
  [feature = 'place_islet'][zoom >= 14][way_pixels > 3000],
  [feature = 'place_islet'][zoom >= 19] {
    text-name: "[name]";
    text-fill: #000;
    text-size: 9;
    [way_pixels > 12000] { text-size: 12; }
    [way_pixels > 48000] { text-size: 15; }
    text-face-name: @oblique-fonts;
    text-halo-radius: 1;
    text-placement: interior;
  }

Seems to work.

Is rendering from zoom level >=7 okay (performance)? Would probably be low enough to solve #988. Can we imagine even bigger islands that should get a label?

My new test code relies on the SQL way_pixels querry of #941 from @math1985. Should I wait until #941 is merged and then rebase? Or is it possible to base a PR on #941 even before this one is merged?

[matthijsmelissen]

My new test code relies on the SQL way_pixels querry of #941 from @math1985. Should I wait until #941 is merged and then rebase? Or is it possible to base a PR on #941 even before this one is merged?

If you like, you can change the SQL queries already in this PR, and I will rebase #941.

[sommerluk]

Okay.

The code is available at https://github.com/sommerluk/openstreetmap-carto/compare/islet_names_rendering

But I don't know how I can change this current pull request to the new content. (I'm still new not familiar with Github, but at least know I have a clean setup.) Is it okay to just open a new PR and close this one?

[matthijsmelissen]

Is it okay to just open a new PR and close this one?

Yes, that's perhaps the easiest way.

[sommerluk]

Closing in favor of #990.