Fix shop=car_repair label/icon colour mismatch (brown) #4536
Conversation
The colour of the icon (purple) and the label (brown) don't match. This commit makes the icon brown in line with other service providing amenities. Fixes gravitystorm#2658
jdhoek
changed the title
There was a problem hiding this comment.
This in principle works fine as well, however it introduces brown dot rendering at z17 - which would be a novelty for this style. Unlike shops where almost all variants start at the same zoom level brown symbols start at very different zoom levels so introducing a dot only rendering at the starting zoom level could seem a bit weird. Still this could be discussed as a new design idea, however if you want to do so i would suggest to separate that from the bug fix.
As written in #4535 i am not partial to either of the color choices but would like to see a consistent criterion being developed, applied and documented for that.
It does not introduce a dot at z17. A purple dot(as shops) is rendered in the current rendering. See https://www.openstreetmap.org/#map=18/51.42782/5.44144 Car repair shops belong to amenity shop types like |
|
I also agree on the purple colour being the better option. Closing in favour of that PR. |
The colour of the icon (purple) and the label (brown) don't match.
This commit makes the icon brown in line with other service providing
amenities.
Fixes #2658
This is one of two ways to solve this. The other colour choice is shown in #4535. These two PR's are mutually exclusive.
Either one is probably better than:
Before
After