Fix shop=car_repair label/icon colour mismatch (purple) #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The colour of the icon (purple) and the label (brown) don't match. This commit makes the label purple to match most other `shop=*` tags. Fixes gravitystorm#2658
This was referenced Apr 21, 2022
jdhoek
changed the title
imagico
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
This looks fine and renders as expected. Nice to see this being fixed.
I don't have any strong preference regarding the color, both choices seem in principle fine with me. So far we don't have a very consistent scheme of colors with symbols. I would suggest to:
- think about a practically verifiable criterion to determine if some feature is to be rendered in shop color or a different color.
- Then apply it to the choice here and
- document it so others can follow the same principle with other changes
And the criterion should of course not be the key used by the tag - that does not follow any consistent rules.
|
I approve this change (I have not tested the rendering but the code change looks fine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colour of the icon (purple) and the label (brown) don't match.
This commit makes the label purple to match most other
shop=*tags.Fixes #2658
This is one of two ways to solve this. The other colour choice is shown in #4536. These two PR's are mutually exclusive.
Either one is probably better than:
Before
After