Water slide #3346

johsin18 · 2018-08-15T14:33:45Z

Changes proposed in this pull request:

Render attraction=water_slide similar to a (water) stream
Render a marker for water slide
Render the name of the water slide

This is more a proof of goodwill, probably both the rendering and the code have to be further improved, as I'm a complete newbie to this.
In particular, the marker is hidden unter the slide, how can I fix that? However, I'm not so sure the marker makes sense, anyway.

Test rendering with links to the example places:
https://www.openstreetmap.org/way/353735844

Before

After

johsin18 · 2018-08-15T14:34:54Z

water.mss

+  [attraction = 'water_slide'] {
+    [zoom >= 15] {
+      [zoom >= 17] {
+        bridgecasing/line-color: saturate(darken(@water-color, 40%), 30%);


Actually, I'm not sure what the prefix "bridgecasing" references to here. Is it really needed?

johsin18 · 2018-08-15T14:35:09Z

water.mss

+        [zoom >= 18] { bridgecasing/line-width: 3.5; }
+        [zoom >= 19] { bridgecasing/line-width: 7; }
+      }
+      water/line-color: @water-color;


Actually, I'm not sure what the prefix "water" references to here. Is it really needed?

johsin18 · 2018-08-15T14:35:57Z

project.mml

-            AND (bridge IS NULL OR bridge NOT IN ('yes', 'aqueduct'))
+          WHERE (waterway IN ('river', 'canal', 'stream', 'drain', 'ditch', 'wadi')
+                 AND (bridge IS NULL OR bridge NOT IN ('yes', 'aqueduct')))
+            OR attraction IN ('water_slide')


Is it okay after all to use the "water-lines" for the water slides?

polarbearing · 2018-08-15T17:08:31Z

I wonder why you place the symbol at the beginning of the slide? Usually here, symbols are in the middle of the feature.

lakedistrictOSM · 2018-08-15T17:35:38Z

Thanks for this PR.

I'm not sure what the icon is supposed to be but it's probably unnecessary anyway.

What zoom level are you starting from? If I'm reading the code correctly z15 might be too early.

sommerluk · 2018-08-15T17:39:14Z

Hi @johsin18

Thanks for making a Pull Request. You’re welcome!

While I didn’t do neither a cartographic nor a code review (and don’t have time to do it currently), as a first impression I feel this is a feature for starting rather with zoom level 18 or 19.

Best regards and thanks again for the PR!

Tomasz-W · 2018-08-15T18:09:30Z

@johsin18 My remarks:

icon (?) is unnecessary here
for me this way looks just like a stream flowing out of water body (more like a natural feature than a human-made one), can you try with leisure=pitch green way fill and dark-blue outline?

Thanks for this PR and good luck! :)

PS. There should be a way of highway=steps connected with attraction=water_slide added at the end, then it would be more intutive.

HolgerJeromin · 2018-08-15T21:57:17Z

perhaps we need a bridge like border. In fact a slide is kind of a bridge

johsin18 · 2018-08-16T05:38:59Z

Thanks for all your comments.

I will drop the icon, nobody (including me) likes it ;-)
about the zoom level: let's start at 17, otherwise it pops up too suddenly IMHO. After all, the feature is quite large usually
about the color: I will try with some that is more consistent with man-made features
@Tomasz-W Once water slides are actually rendered, people will have a motivation to map the corresponding steps. Right now, it would look like a stairway to heaven ;-) And actually, this problem will stay for zoom levels where the slide is not yet shown, but just the steps (so should we go to 16 then maybe?)
@HolgerJeromin How should it become more similar to a bridge border? Different outline color? Some white "casing" in between (how would I achieve that)?

Can you please comment on the code (and my questions added as comments there)?
Is the code in the right place? Does it not cause efficiency problems maybe?

johsin18 · 2018-08-16T13:25:31Z

So I have made some of the proposed changes, simplified the code, and moved everything to amentiy-points.mss, which seems to make more sense. It is rendered from zoom level 16 now, due to the usual size of such slides.

I show screenshots on are more complex example:
https://www.openstreetmap.org/#map=19/47.53818/7.62098

How could I make the junction at the very top smoother? It's common to assemble as slide from multiple ways in multiple layers, as you would have self-intersecting ways otherwise. Should/could they be combined with some kind of relation?

kocio-pl · 2018-08-16T13:38:39Z

openstreetmap-carto.style

@@ -14,6 +14,7 @@ node,way   admin_level  text         linear
 node,way   aerialway    text         linear
 node,way   aeroway      text         polygon
 node,way   amenity      text         polygon
+node,way   attraction   text         polygon


I'm not sure if and how this works. Typically we don't change this file, since it would require database reload, which is very time consuming and is rarely done on OSMF servers.

In cases when the column is not defined when creating database, we use the hstore column with construction tags->'foobar', see for example this very short PR with icao and iata value check: https://github.com/gravitystorm/openstreetmap-carto/pull/2674/files

kocio-pl · 2018-08-16T13:41:51Z

I'm not sure what works better - water with casing or pitch with casing.

johsin18 · 2018-08-16T14:14:06Z

Ok I have removed the change to openstreetmap-carto.style.

Tomasz-W · 2018-08-16T14:59:14Z

@kocio-pl Notice that function of water slides is to allow people to fastly flow down by water and gravity, not to just move water from one place to another. It makes water slides closer to running track than a typical water stream ;)

matthijsmelissen · 2018-08-16T15:03:37Z

Thanks for your proposal, @johsin18! However, I still think this is too specific for a general purpose map, and I don't think we should accept this PR.

matthijsmelissen · 2018-08-16T15:04:25Z

It's also not clear to me what the usecase of rendering waterslides is.

dieterdreist · 2018-08-16T15:11:24Z

sent from a phone

On 16. Aug 2018, at 17:05, Matthijs Melissen ***@***.***> wrote: It's also not clear to me what the usecase of rendering waterslides is.

details like this help to make the map look better (ideally) and help people to orient theirselves on the map. Certainly this isn’t aiming at routing.

kocio-pl · 2018-08-16T15:34:02Z

After some time (a year?) contemplating use case idea, I'm starting to think this is not the best tool for making general map using grass root data.

For me it's rather about reflecting the reality, especially "on the ground" truth (with some exceptions like tunnels), secondary aim is the quick check what is the state of database (rough feedback loop on completeness and quality). Maybe I would see use cases as a third level - if we have some problem with too much data, we can think how to filter them.

In case of waterslides (1) this is what's visible on the ground, (2) it helps to check if the tagging is there and (3) it probably never competes with some other objects in such places, so no need to filter it other than using scaling rule (initial zoom level should be proportional to the typical size).

dieterdreist · 2018-08-16T15:50:34Z

waterslides also often quite significant in the landscape/surroundings as they have to be higher if they should be longer

HolgerJeromin · 2018-08-16T19:58:38Z

How should it become more similar to a bridge border? Different outline color? Some white "casing" in between

All bridges have a black stroke. Even water bridges:

openstreetmap-carto/water.mss

Lines 134 to 144 in 14e9349

    
           [bridge = 'yes'] { 
        
             [zoom >= 14] { 
        
               bridgecasing/line-color: black; 
        
               bridgecasing/line-join: round; 
        
               bridgecasing/line-width: 6; 
        
               [zoom >= 15] { bridgecasing/line-width: 7; } 
        
               [zoom >= 17] { bridgecasing/line-width: 11; } 
        
               [zoom >= 18] { bridgecasing/line-width: 13; } 
        
             } 
        
           }

meased · 2018-08-17T01:10:17Z

Use cases :

Orientation (just about everything has this usecase).
Discovering details about an attraction.
- Not all usecases are using the map to assist with travel, sometimes people just want to browse around to see what's there, which is in itself a usecase.
Providing feed back for people mapping water parks.
- Water parks are much more likely to be micro mapped.
Shows off the richness of OSM.

Really, pretty close to the usecases of rendering swimming pools or pitches.

I like blue better. Swimming pools aren't for holding water, they're for swimming in. Why aren't they pitch green?

Also, I think

line-join: round;
line-cap: round;

would look good.

kocio-pl · 2018-08-17T01:16:24Z

So maybe the blue line with a black (bridge-like) outline?

BTW: it's amazing to me that this PR attracts so much attention. I don't understand why, but I'm happy with that.

polarbearing · 2018-08-17T11:18:27Z

this PR attracts so much attention. I don't understand why

Because this summer is so hot?

I prefer the pitch colour. As said before, the prime function is to slide. Water is just the lubricant, not the medium as in the pool. The pitch colour would also apply to dry slides where people sit on a rag.

johsin18 · 2018-08-17T13:36:02Z

Ok so I changed the casing color to black, as there seems to be a consensus on that.
For the interior color (pitch or pool) I don't care too much.
Adding line-cap is not a good idea, as it puts a break between two connected slide segments. Also, a water slide is always open at both ends, so it does not match reality well.
There is still a narrow black line between the two segments, I'm afraid, is there a way to avoid it completely?

kocio-pl · 2018-08-17T22:02:19Z

Could you render this version? It makes a lot of sense to make visualization of every change.

johsin18 · 2018-08-20T07:19:54Z

These are the renderings of the latest code (inner pitch, outer black)

Tomasz-W · 2018-08-20T08:17:13Z

Is it possible to not render black outline on ways ends, but only on its sides? Water slides are open at start point and end point, so lack of outline there would be better visualisation of reality.

johsin18 · 2018-08-20T08:36:30Z

line-cap: round;
(just for the inner) helps here, but I'm not sure it's a clean solution:

polarbearing · 2018-08-20T08:38:27Z

keeping the ends open is also important to have no lines between segments (probably the segments are ther for different layer tags). Thus this is better now in this aspect also.

johsin18 · 2018-08-21T05:54:18Z

So would please somebody merge this PR? In the upcoming weeks I will have little time to further work on this.

kocio-pl · 2018-08-21T10:34:20Z

Other examples with new rendering:

https://www.openstreetmap.org/#map=19/47.42822/9.66942

https://www.openstreetmap.org/way/591252087#map=19/54.11311/22.93798

kocio-pl · 2018-08-21T10:39:32Z

amenity-points.mss

+        text-halo-fill: @standard-halo-fill;
+        text-placement: line;
+        text-vertical-alignment: middle;
+        text-repeat-distance: @waterway-text-repeat-distance;


I feel this is not needed for such short features.

I tried to remove it, but then I got the name twice even on quite short slides.

I see - surprising side effect. 😄

polarbearing · 2018-08-21T10:54:20Z

looks visually good to me

kocio-pl · 2018-08-21T11:20:42Z

Thanks for the code and nice tuning, it made people really interested. 😄

Tomasz-W · 2018-08-21T12:02:40Z

@johsin18 Big thanks for this PR! If you will have some time and will in future, please look at task lists in #3298 (comment) and #3298 (comment). Maybe there is something which you could help us with :)

kocio-pl · 2018-08-30T10:41:05Z

I've just found a place with many water slides mistagged as streams:

https://www.openstreetmap.org/#map=19/37.97477/-122.05156

polarbearing · 2018-08-30T18:41:05Z

We should wait til the release is through, so we can tell him how much better they would have looked if he hadn't tagged for the renderer so blatantly ;-)

kocio-pl · 2018-08-30T19:10:59Z

He was smarter and used double tagging... 😄

johsin18 commented Aug 15, 2018

View reviewed changes

Tomasz-W mentioned this pull request Aug 16, 2018

Good first issues [meta-ticket] #3298

Closed

26 tasks

johsin18 force-pushed the water-slide branch from 6785ffb to 2457735 Compare August 16, 2018 13:17

kocio-pl reviewed Aug 16, 2018

View reviewed changes

johsin18 force-pushed the water-slide branch from 2457735 to 280df4a Compare August 16, 2018 14:13

johsin18 force-pushed the water-slide branch from 280df4a to f7ca254 Compare August 17, 2018 13:32

johsin18 force-pushed the water-slide branch from f7ca254 to ecb6db4 Compare August 17, 2018 13:37

johsin18 added 2 commits August 20, 2018 12:53

Render attraction=water_slide (gravitystorm#3335).

d26f2a5

Render name for attraction=water_slide (gravitystorm#3335).

5de04f5

johsin18 force-pushed the water-slide branch from ecb6db4 to 5de04f5 Compare August 20, 2018 10:53

kocio-pl reviewed Aug 21, 2018

View reviewed changes

kocio-pl merged commit fd473eb into gravitystorm:master Aug 21, 2018

Tomasz-W mentioned this pull request Aug 31, 2018

Rendering leisure=track on lines #2632

Closed

kocio-pl mentioned this pull request Sep 24, 2018

Layer not respected in attraction=water_slide #3413

Closed

jeisenbe mentioned this pull request Apr 3, 2020

Linear features inappropriately rendered in amenity-line layer #4104

Open

imagico mentioned this pull request Dec 21, 2020

Render names of attraction=* #4268

Open

imagico mentioned this pull request Mar 19, 2023

feat: Render roller_coaster=track ✨🎢 #4666

Merged

Water slide #3346

Water slide #3346

Conversation

johsin18 commented Aug 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

polarbearing commented Aug 15, 2018

lakedistrictOSM commented Aug 15, 2018

sommerluk commented Aug 15, 2018

Tomasz-W commented Aug 15, 2018 • edited Loading

HolgerJeromin commented Aug 15, 2018

johsin18 commented Aug 16, 2018

johsin18 commented Aug 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kocio-pl commented Aug 16, 2018

johsin18 commented Aug 16, 2018

Tomasz-W commented Aug 16, 2018 • edited Loading

matthijsmelissen commented Aug 16, 2018

matthijsmelissen commented Aug 16, 2018

dieterdreist commented Aug 16, 2018 via email

kocio-pl commented Aug 16, 2018

dieterdreist commented Aug 16, 2018 via email

HolgerJeromin commented Aug 16, 2018 • edited Loading

meased commented Aug 17, 2018

kocio-pl commented Aug 17, 2018

polarbearing commented Aug 17, 2018

johsin18 commented Aug 17, 2018 • edited Loading

kocio-pl commented Aug 17, 2018

johsin18 commented Aug 20, 2018

Tomasz-W commented Aug 20, 2018

johsin18 commented Aug 20, 2018

polarbearing commented Aug 20, 2018

johsin18 commented Aug 21, 2018

kocio-pl commented Aug 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

polarbearing commented Aug 21, 2018

kocio-pl commented Aug 21, 2018

Tomasz-W commented Aug 21, 2018 • edited Loading

kocio-pl commented Aug 30, 2018

polarbearing commented Aug 30, 2018

kocio-pl commented Aug 30, 2018

Tomasz-W commented Aug 15, 2018 •

edited

Loading

Tomasz-W commented Aug 16, 2018 •

edited

Loading

HolgerJeromin commented Aug 16, 2018 •

edited

Loading

johsin18 commented Aug 17, 2018 •

edited

Loading

Tomasz-W commented Aug 21, 2018 •

edited

Loading