Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for water slides (attraction=water_slide) #3335

Closed
johsin18 opened this issue Aug 8, 2018 · 5 comments · Fixed by #3346
Closed

Add rendering for water slides (attraction=water_slide) #3335

johsin18 opened this issue Aug 8, 2018 · 5 comments · Fixed by #3346

Comments

@johsin18
Copy link
Contributor

johsin18 commented Aug 8, 2018

Expected behavior

Should be rendered as a path (blueish?) and an appropriate icon if mapped as a way.
Should be rendered as just the icon if mapped as a node.
The icon could be a man on a sloping line.

Actual behavior

Not rendered at all.

Links and screenshots illustrating the problem

Tag description:
https://wiki.openstreetmap.org/wiki/Tag:attraction%3Dwater_slide
It "suggests" to make it waterway=stream in addition, to force it being rendered, but is that a valid approach?

Example occurrence:
https://www.openstreetmap.org/#map=19/47.52249/7.56949

@kocio-pl kocio-pl added this to the New features milestone Aug 8, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 8, 2018

I guess it should be rendered the same as a stream, but with the dark blue outline (to show similarity to swimming pool). I would probably not render nodes and icons.

Would you like to try make the code? We lack coders, so it's best to try on your own.

@matthijsmelissen
Copy link
Collaborator

I think this is too specific for our general purpose map.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 8, 2018

With generic water-like rendering I don't see the problem. It would look like swimming pool extension and won't create problem anywhere else.

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Aug 9, 2018

Our waterpark icon is similar than the suggested icon, isnt it?

@johsin18
Copy link
Contributor Author

So I will try to come up with a PR. However, it seems that "attraction=*" without "tourism=attraction" is not rendered at all so far, so I also have to change some DB queries.
Into what .mss file should it be inserted? water.mss, amenity_point.mss, or water-features.mss? Or even a new one? I guess I should not integrate it too tightly with waterway=stream, should I?

johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 14, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 15, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 15, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 15, 2018
@johsin18 johsin18 mentioned this issue Aug 15, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 16, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 16, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 16, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 16, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 17, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 17, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 17, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 17, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 20, 2018
johsin18 added a commit to johsin18/openstreetmap-carto that referenced this issue Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants