Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added text-repeat-distance for all waterways (part of #3295) #3317

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Added text-repeat-distance for all waterways (part of #3295) #3317

merged 1 commit into from
Jul 27, 2018

Conversation

Penegal
Copy link
Contributor

@Penegal Penegal commented Jul 23, 2018 •
edited
Loading

This PR adds text-repeat-distance for all waterways; it belongs to the split of #3295 in several PRs.

Before/after test renderings:
19615979274965_old_waterway
19615979274965_new_waterway
https://www.openstreetmap.org/#map=17/48.19305/6.41723

276852628763216_old_waterway
276852628763216_new_waterway
https://www.openstreetmap.org/#map=18/48.27490/6.14848

475922843840436_old_waterway
475922843840436_new_waterway
https://www.openstreetmap.org/#map=16/48.4706/6.1019

Edit: added links to test locations.

@Penegal Penegal mentioned this pull request Jul 23, 2018
Closed
@Tomasz-W
Copy link

@Penegal Please add auto-closing keyword for #3111 in first post.

@Penegal
Copy link
Contributor Author

Penegal commented Jul 23, 2018

@Tomasz-W: I just edited #3318 for that, as #3111 was more about roads and #3318 will complete #3315 to fix that.

@kocio-pl
Copy link
Collaborator

Looks OK for me, makes just a slight difference. It only skips some too cluttered labels while not touching the ones with a proper space.

river

Before
ruynotr_

After
kijxqlaz

canal

Before
f4aqp_ir

After
xud22ij

stream

Before
3zndhjtt

After
cabkkbyo

@kocio-pl kocio-pl merged commit 14e9349 into gravitystorm:master Jul 27, 2018
@kocio-pl
Copy link
Collaborator

I'm glad that it's done, thanks!

@kocio-pl kocio-pl mentioned this pull request Jul 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocio-pl kocio-pl kocio-pl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Penegal @Tomasz-W @kocio-pl