Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterway's name render is inconsistent. #2411

Closed
DaveF63 opened this issue Oct 12, 2016 · 11 comments
Closed

Waterway's name render is inconsistent. #2411

DaveF63 opened this issue Oct 12, 2016 · 11 comments

Comments

@DaveF63
Copy link

DaveF63 commented Oct 12, 2016

Hi
https://www.openstreetmap.org/#map=17/51.39099/-2.34528

There's an inconsistency between the rendering of the waterway's name for rivers & canals. Is this intentional? Would it be better if they occurred at the same frequency?
Personally I think rivers render slightly too often & canals not frequently enough. Maybe a compromise to somewhere in the middle?

@pnorman
Copy link
Collaborator

pnorman commented Oct 12, 2016

looks like rivers have text-spacing: 400; and canals have nothing set

@DaveF63
Copy link
Author

DaveF63 commented Oct 13, 2016

Is that in pixels? Maybe 600/800 for both?

@kocio-pl kocio-pl added the water label Nov 15, 2016
@kocio-pl
Copy link
Collaborator

@DaveF63 Could you try to test these values at least initially?

@kocio-pl kocio-pl self-assigned this Nov 26, 2016
@DaveF63
Copy link
Author

DaveF63 commented Nov 28, 2016

As an end user how would i go about that? Is there a carto sandbox which renders amendments, as the dev sandbox doesn't do it.

@SomeoneElseOSM
Copy link
Contributor

It doesn't cover setting up a test version of OSM Carto from scratch, but I wrote a bit about text spacing in a recent diary entry. That's talking about long distance footpaths, and is not based on the current "standard" style, but those comments should be applicable to that.

@kocio-pl
Copy link
Collaborator

@DaveF63 Now that we have a Docker-based testing environment, you can try test rendering yourself, see:

https://github.com/gravitystorm/openstreetmap-carto/blob/master/DOCKER.md
https://ircama.github.io/osm-carto-tutorials/

@Adamant36
Copy link
Contributor

Here's some examples at different zoom and pixel levels. Unfortunately its only the name of river because I realized after doing it that the canal was miss tagged as a creek. So it didn't change at throughout the process. I figured id at least add examples for the river though since they are going to have the same name spacing anyway. If its an issue, I can redo it.

First we have 600
600 100 to 500 zoom
600 300 to 1000 zoom
600 500 to 1000 zoom
Now 700
700 100 to 500 zoom
700 300 to 1000 zoom
700 500 2000
And finally 800
800 100 to 500 zoom
800 300 1000 zoom
800 500 to 2000 zoom

I didn't do 500 because it was not within the range the original poster mentioned @pnorman mentioned and it seemed to similar to 400 when I looked at it, but I can do that to if anyone wants to see it. Personally, I think 600 is the most even looking, although they all seem to have their pluses and minuses at different zoom levels. 700 seems to have a render problem at 300/1000 zoom, where as 800 has one at 500/2000 zoom. Although that could just be because of the place in the river that the name is located at. Looking back, I probably could have found somewhere straighter to try it out, but it was the only place I knew of close to a canal. Plus, rivers are not always that straight..So...Maybe instead of picking one pixel width for every zoom level, it could be variable.

@kocio-pl
Copy link
Collaborator

I think the most important would be not to fix on one example, but to test at least few different waterways, with different shapes and other features.

It can be not clear from the start which features are relevant to labels rendering (you might get some that are not important even if you think they are, and the other way around), so making some random choices helps to find interesting cases.

Would you like to try?

@Adamant36
Copy link
Contributor

Adamant36 commented Mar 12, 2018

@kocio-pl Good call. It looks like creeks have the same issue. So I'll probably tweak around with them to. Do you think the label spacing should be the same for all types of waterways and is there a preferred zoom level or spacing range to test things with so it would easier to keep track of what I'm doing?

@kocio-pl
Copy link
Collaborator

My working theory would be that streams are smaller and shorter and there are not too many surrounding objects, so they might need more labels than rivers and canals, but this is one of the assumptions that should be checked. I have no idea what zoom levels and range should be tested - the more, the better, until you find some patterns.

What works for me is to start with the objects/places I know and then trying to find something known, strange, different (for example on the other continent) or unusual in some other way and then I try as much as I can handle.

@kocio-pl
Copy link
Collaborator

Effectively closed by #3317.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants