Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brighten built-up areas on z12 #3225

Merged

Conversation

matthijsmelissen
Copy link
Collaborator

@matthijsmelissen matthijsmelissen commented May 8, 2018

This resolves #2777

The brightness sequence from z10 up used to be 212-216-211-223, now it is 212-216-221-223.

Test rendering with links to the example places:

Before
screen shot 2018-05-09 at 00 31 19

After
screen shot 2018-05-09 at 00 31 11

This resolves 2777
@kocio-pl
Copy link
Collaborator

kocio-pl commented May 9, 2018

Thanks! I have to test brightness progression on the map, but this change looks like a proper tuning of midzoom rendering.

@kocio-pl
Copy link
Collaborator

It looks good for me. Colors are well balanced and details are more visible. The downside is that we loose a feeling that built-up areas are coherent for big cities, but we gain more intuitive, gradual color change.

If nobody objects, I plan to merge it tomorrow.

Warsaw, z12

Before
7gxsqjto

After
655zelor

SW of Warsaw, z12

Before
afswf21i

After
nydnm3oe

@kocio-pl kocio-pl merged commit 311cae6 into gravitystorm:master May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

landuse=residential color change
2 participants