Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landuse=residential color change #2777

Closed
Vort opened this issue Aug 26, 2017 · 23 comments · Fixed by #3225
Closed

landuse=residential color change #2777

Vort opened this issue Aug 26, 2017 · 23 comments · Fixed by #3225

Comments

@Vort
Copy link

Vort commented Aug 26, 2017

Hello.

With new style, residential color variation between zoom levels looks arbitrary.
It becomes darker and brighter several times as you zoom in.

z8, z9 - 221 (bright)
z10 - 212 (dark)
z11 - 216 (bright)
z12 - 211 (dark)
z13 - 223 (bright)

And at zoom=12 it looks just bad in my opinion:
(residential areas receives too much emphasis)
z12_bad

Before-after comparison:
z12_change

@kocio-pl kocio-pl added this to the Bugs and improvements milestone Aug 26, 2017
@matthijsmelissen
Copy link
Collaborator

This is becajse not all of the tiles have been re-rendered yet. Wait a day or so and it should be better.

@Vort
Copy link
Author

Vort commented Aug 26, 2017

@math1985, no, all colors was checked for updated tiles.
My last screenshot was intentionally half-updated to show the differences.
Please reopen the issue.

@matthijsmelissen
Copy link
Collaborator

Reopening.

@mboeringa
Copy link

And at zoom=12 it looks just bad in my opinion:

Actually, I think part of the problem is that the darker colour now more clearly reveals where there are missing residential polygons. In the first image you posted, there are clearly large missing sections, causing a "broken up" look of the residential area, which I think is part of what causes the undesirable look.

However, that is not an issue of the colour change per se, but may actually be an incentive to start mapping them!

Especially in well mapped countries like e.g. the Netherlands, where almost the total surface area is somehow tagged, including residential areas, the colour doesn't look that bad... E.g.:

http://www.openstreetmap.org/#map=12/52.3504/4.7766

(I realize that the "ideal" situation is unlikely in much larger countries due to much less human influence and maybe no sensible natural tags to cover large swaths of land)

@Vort
Copy link
Author

Vort commented Aug 27, 2017

That color at z12 also "hides" residential roads.

@mboeringa
Copy link

That color at z12 also "hides" residential roads.

Although the colour could potentially be maybe a bit lighter, at Z12 and lower zoom levels, the fact that it partially "hides" residential roads is for the most part a positive thing. At Z12, residential roads really cannot be displayed without causing a huge amount of clutter or high frequency noise in the image, especially in (historic) cities and countries with very dense build up.

Only at Z13 does the display of residential roads really become palatable...

@boothym
Copy link
Contributor

boothym commented Aug 27, 2017

Hard to tell the difference between industrial and residential areas at z11, one or the other needs to be fixed.

@kocio-pl
Copy link
Collaborator

@boothym It's on purpose - they are rendered the same until z13+:

[feature = 'landuse_industrial'][zoom >= 10] {
polygon-fill: @built-up-lower-lowzoom;
[zoom >= 11] { polygon-fill: @built-up-upper-lowzoom; }
[zoom >= 13] { polygon-fill: @industrial; }

@boothym
Copy link
Contributor

boothym commented Aug 29, 2017

I realise that, but surely they should be different so you can tell them apart? Can't you make industrial more pink/purple like z13+?

@kocio-pl
Copy link
Collaborator

We try to hide the differences between some human landuses, because they are small compared to natural areas on midzoom. I think that only some big human-related areas (like forests, farmlands and military zones - possibly some others too) are worth showing here.

@boothym
Copy link
Contributor

boothym commented Aug 30, 2017

Sure, but there are some big industrial areas as well - for example: https://www.openstreetmap.org/#map=14/53.4699/-2.3257 - zoom out to z12 and it just becomes part of the big grey blob that is Manchester.

@kocio-pl
Copy link
Collaborator

It's still small compared to nature on midzoom. It's big on z14, not-so-big on z13 and on z12 it's just a tiny part of the screen, so for me it's good that it's not anything special on that zoom.

@matkoniecz
Copy link
Contributor

And at zoom=12 it looks just bad in my opinion:

Residential seems to become lighter at zooming to z13

For example at http://www.openstreetmap.org/#map=12/52.1863/20.8790

@built-up-upper-lowzoom: #c0c0c0;
(...)
@residential: #e0dfdf; // Lch(89,0,0)
(...)
[zoom >= 11] { polygon-fill: @built-up-upper-lowzoom; }
[zoom >= 13] { polygon-fill: @residential; }

is a relevant code, so at zooming in to z13 it becomes lighter.

I agree that it is really strong at z12, too strong in cities that I checked.


It becomes darker and brighter several times as you zoom in.

@Vort Can you check this again? From testing and reading code seems that it is not happening.

@Vort
Copy link
Author

Vort commented Oct 22, 2017

@matkoniecz: here is the result of retest:

carto_residential

@matkoniecz
Copy link
Contributor

It is likely to be a rediscovery of #1940

@Vort
Copy link
Author

Vort commented Oct 22, 2017

Can anyone make lossless tiles for checking?

BTW, #c0 = 192.
211 and 216 are too far from it.

@Vort
Copy link
Author

Vort commented Oct 22, 2017

@matkoniecz, I have found a place, where are too little colours used, so that 256 colour palette becomes semi-empty.
Result is still 216/211 for z11/z12.
If that's a result of quantization, then it is done wrong.

tile_palette

@matkoniecz matkoniecz changed the title Residential color change landuse=residential color change Jan 14, 2018
@kocio-pl
Copy link
Collaborator

I started to dislike z12 residential rendering and would like it to be like on z11. Anybody interested in testing it?

@matthijsmelissen
Copy link
Collaborator

I also noticed this independently. Residential on z12 should be lighter.

@boothym
Copy link
Contributor

boothym commented Mar 26, 2018

I notice landuse=railway and industrial on z11/12 are not the same - I'd like to suggest industrial is changed to match railway so that it retains its light purple colour and is different to residential.

@kocio-pl
Copy link
Collaborator

I would not change it. Typically railway are used for long, thin rail related landuses, so should be light to let the rails be visible, but industrial tend to be like other landuses and it indicates human activity and presence area, similar to residential in that respect (which is not true in general for railways).

@boothym
Copy link
Contributor

boothym commented Mar 26, 2018

Well you don't really see the railway landuse around rails on z12 because the area is too small. But I noticed the difference with a railway yard next to an industrial area: https://osm.org/go/evfhVRh--?m=

On z13+ railway and industrial are the same, but on z11-12 they are not. So one needs to change - I'd prefer it if industrial changed to match railway so that it is different to residential.

@kocio-pl
Copy link
Collaborator

On z13+ railway and industrial are the same, but on z11-12 they are not. So one needs to change

But why? They are different tags, so they can behave differently when the difference is important (midzoom), even when sometimes they are similar (high zoom) and they can look similar. I feel this is good when you are able to detect a meaning by visual differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants