Adding rendering for amenity=parking_entrance [WIP] #2875

kocio-pl · 2017-10-01T02:49:33Z

Resolves #270.
Related to #552 (comment).

This is a draft which renders such entrances but only for parking=underground, because other parkings are visible in our style anyway. I plan to:

add the name rendering (it might be useful to know which underground object it leads to)
restrict rendering only to access=yes and access=permissive (there's too many of private underground parkings)

Example:

pnorman

The MSS looks okay, but the SQL needs some changes.

The icon looks okay, but I haven't reviewed it for pixel alignment.

pnorman · 2017-10-01T20:26:08Z

project.mml

@@ -1427,6 +1427,7 @@ Layer:
            tags->'power_source' as power_source,
            tags->'icao' as icao,
            tags->'iata' as iata,
+            tags->'parking' as parking,


What does another column do to the number of combinations, and does it cause problems with a combinatorial explosion?

I have no deeper understanding of SQL in layers - I just try to make it work and look similar to other features. Some guidelines or tutorial for adding things would be welcome.

What you think should be done here?

https://vimeo.com/68093876 talks about the problem starting at 10:52-14:21. The best way to check this isn't a problem here is to compare the line count of the XML output. If it increases by a dozen lines, that's fine. If it increases by 10000 lines, it's a problem.

I suspect this is okay, but I'm not 100% sure. If you added something that styled all objects with some parking value then it would definitely be a problem.

Most of the code I have ever added to osm-carto was some SVG XML for icons, so that's probably not the case for me.

I understand the combinatorial explosion principle, my problem is rather what you can see at 16:40. Some common layers are so complex, that they don't even fit on the screen, so it's hard to know which visual section is needed and how should it look like.

I refer to "visual sections", because with so many elements it's hard to see the logical structure and know what is nested inside something other - even with all the indents. Maybe putting some of the lists into variables or including them from other files would help, if it's possible?

Where can I find those generated XML files, in particular having a setup closely following
https://github.com/gravitystorm/openstreetmap-carto/blob/master/DOCKER.md
?

You just need CartoCSS:

https://github.com/mapbox/carto#installation

Then you can just run:

carto openstreetmap-carto/project.mml > project.xml

It might be easier to go inside the running container and use existing Kosmtik module:

docker exec -it openstreetmapcarto_kosmtik_1 \ /usr/lib/node_modules/kosmtik/node_modules/carto/bin/carto \ /openstreetmap-carto/project.mml > project.xml

You might remember that carto can be run against desired API version using -a.

pnorman · 2017-10-01T20:26:24Z

project.mml

@@ -1457,6 +1458,7 @@ Layer:
            OR historic IN ('memorial', 'monument', 'archaeological_site')
            OR tags->'memorial' IN ('plaque')
            OR highway IN ('bus_stop', 'elevator', 'traffic_signals')
+            OR tags->'parking' IN ('underground')


I don't see that we need to change the WHERE clause

What do you suggest tu put here?

Indeed, this case should be already covered by "OR amenity IS NOT NULL"

pnorman · 2017-10-01T20:28:03Z

project.mml

@@ -1499,7 +1501,7 @@ Layer:
                                                  'police', 'post_box', 'post_office', 'pub', 'biergarten', 'recycling', 'restaurant', 'food_court',
                                                  'fast_food', 'telephone', 'taxi', 'theatre', 'toilets', 'drinking_water',
                                                  'prison', 'hunting_stand', 'nightclub', 'veterinary', 'social_facility',
-                                                  'charging_station', 'arts_centre', 'ferry_terminal') THEN amenity ELSE NULL END,
+                                                  'charging_station', 'arts_centre', 'ferry_terminal', 'parking_entrance') THEN amenity ELSE NULL END,


Are there other cases where we've added something to this query, but not the one above?

You mean amenity-points but not amenity-points-poly? I don't know, I just saw on the wiki that it's allowed only on nodes. I'm still undecided however if should I add it to amenity-line, since it makes sense to tag the service highway.

What's your opinion?

pnorman · 2017-10-01T20:28:46Z

project.mml

@@ -1564,6 +1567,7 @@ Layer:
            OR tags @> 'emergency=>phone'
            OR highway IN ('bus_stop', 'elevator', 'traffic_signals')
            OR tags @> 'ford=>yes' OR tags @> 'ford=>stepping_stones'
+            OR tags->'parking' IN ('underground')


As above with the WHERE clause

How should I correct it?

kocio-pl · 2017-10-01T22:13:43Z

The icon looks okay, but I haven't reviewed it for pixel alignment.

I've tried to make "P" 1 px wide where possible, but that makes it hardly visible, so now it's mostly rescaled parking icon. Arrow uses points on the matrix, but since it's diagonal, I would rather not call it pixel aligned.

pnorman · 2017-10-01T22:21:38Z

You're going to need to rebase the SQL changes since I merged #2866, but that makes the changes simpler.

With those changes, amenity=parking_entrance meets the WHERE clause conditions and no changes need to be made to that part of the SQL.

matthijsmelissen · 2018-05-07T20:40:34Z

@kocio-pl Are you planning to continue working on this?

kocio-pl · 2018-05-07T20:43:41Z

Yes, I can resolve conflicts soon, but there are still some unanswered questions and that's why this code is still waiting.

meased · 2018-05-19T19:22:18Z

Here is a pixel aligned version of the icon.

Before/After

kocio-pl · 2018-05-19T20:40:43Z

So much better - thanks!

pnorman · 2018-05-28T03:12:33Z

Questions answered, but we still need to know the change in lines of XML so we know if it's causing a combinatorial problem or not.

polarbearing · 2018-08-19T17:06:39Z

The icon should be transparent when an access tag is set. Probably just copy the two lines as used for parking.
SVG code can be optimised by stripping the metadata, I usually do that in vi or another text editor.

kocio-pl · 2018-08-20T00:48:06Z

I prefer not to show any of the private entrances - it's too many of them and they would clutter the view.

polarbearing · 2018-08-20T08:33:14Z

not to show any of the private entrances

Both (transparent or not at all) is fine with me. Just did not see that in the code yet.

HolgerJeromin · 2018-08-20T20:23:53Z

what about rendering private ones really late?

kocio-pl · 2018-08-20T20:26:55Z

I'm suspicious, but not completely against. z19+ might work - it just needs testing to make sure.

johsin18 · 2018-11-04T10:59:44Z

I would love to see parking entrances rendered. How can I help to get this PR merged?

kocio-pl · 2018-11-04T13:49:46Z

Could you review code comments and probably make a fork with a proper code I could test?

pnorman requested changes Oct 1, 2017

View reviewed changes

Adding rendering for amenity=parking_entrance

8cd87da

kocio-pl force-pushed the parking-entrance branch from 0b5bb0f to 8cd87da Compare October 1, 2017 22:33

kocio-pl mentioned this pull request Nov 21, 2017

Parking too prominent #2904

Closed

Tomasz-W mentioned this pull request Apr 20, 2018

Add rendering for amenity=* and office=* #108

Closed

22 tasks

kocio-pl mentioned this pull request May 19, 2018

Add rendering for amenity=parking_entrance #270

Closed

kocio-pl mentioned this pull request Jul 23, 2018

Water areas with tunnel=yes should not render above landcover #3312

Open

Parking entrance icon update

152acd7

johsin18 pushed a commit to johsin18/openstreetmap-carto that referenced this pull request Nov 9, 2018

Add graphics for parking entrance (gravitystorm#2875).

4d6ff27

johsin18 added a commit to johsin18/openstreetmap-carto that referenced this pull request Nov 9, 2018

Added rendering for amenity=parking_entrance (gravitystorm#2875).

f1b8157

johsin18 mentioned this pull request Nov 9, 2018

Parking entrance #3505

Merged

kocio-pl closed this in #3505 Nov 12, 2018

kocio-pl deleted the parking-entrance branch November 13, 2018 10:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding rendering for amenity=parking_entrance [WIP] #2875

Adding rendering for amenity=parking_entrance [WIP] #2875

kocio-pl commented Oct 1, 2017 •

edited

Loading

pnorman left a comment

pnorman Oct 1, 2017

kocio-pl Oct 1, 2017

pnorman Oct 1, 2017

kocio-pl Oct 1, 2017

johsin18 Nov 4, 2018

kocio-pl Nov 5, 2018

pnorman Oct 1, 2017

kocio-pl Oct 1, 2017

pnorman May 28, 2018

johsin18 Nov 4, 2018

pnorman Oct 1, 2017

kocio-pl Oct 2, 2017

pnorman Oct 1, 2017

kocio-pl Oct 1, 2017

kocio-pl commented Oct 1, 2017 •

edited

Loading

pnorman commented Oct 1, 2017

matthijsmelissen commented May 7, 2018

kocio-pl commented May 7, 2018

meased commented May 19, 2018

kocio-pl commented May 19, 2018

pnorman commented May 28, 2018

polarbearing commented Aug 19, 2018

kocio-pl commented Aug 20, 2018

polarbearing commented Aug 20, 2018

HolgerJeromin commented Aug 20, 2018

kocio-pl commented Aug 20, 2018

johsin18 commented Nov 4, 2018

kocio-pl commented Nov 4, 2018

Adding rendering for amenity=parking_entrance [WIP] #2875

Adding rendering for amenity=parking_entrance [WIP] #2875

Conversation

kocio-pl commented Oct 1, 2017 • edited Loading

pnorman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kocio-pl commented Oct 1, 2017 • edited Loading

pnorman commented Oct 1, 2017

matthijsmelissen commented May 7, 2018

kocio-pl commented May 7, 2018

meased commented May 19, 2018

kocio-pl commented May 19, 2018

pnorman commented May 28, 2018

polarbearing commented Aug 19, 2018

kocio-pl commented Aug 20, 2018

polarbearing commented Aug 20, 2018

HolgerJeromin commented Aug 20, 2018

kocio-pl commented Aug 20, 2018

johsin18 commented Nov 4, 2018

kocio-pl commented Nov 4, 2018

kocio-pl commented Oct 1, 2017 •

edited

Loading

kocio-pl commented Oct 1, 2017 •

edited

Loading