-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better line spacing #2730
Better line spacing #2730
Conversation
Could you also show examples how would other scripts look like with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screenshots look good to me, but I haven't tested the code.
Thanks! By the way, it would also make sense to keep the wrap-width a constant em amount. |
Closed without testing with Myanmar ? |
And still no test for Arabic : (high Khufi font, suitable for real trafic signs where they are isolated and have cumfortable line-height) or UI font (better suited for multilingual text on a dense map) ? |
Could you provide test rendering for missing scripts? |
Resolves #2358 (last part is solved by this PR)
Before:
After: