Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography for amenity-points.mss #2600

Closed
sommerluk opened this issue Mar 26, 2017 · 5 comments
Closed

Typography for amenity-points.mss #2600

sommerluk opened this issue Mar 26, 2017 · 5 comments

Comments

@sommerluk
Copy link
Collaborator

I was thinking about typography tuning for amenity-points.mss but with #2589 and #2597 open, I’m not sure if it’s the right moment…

CC @math1985 @nebulon42

@matthijsmelissen
Copy link
Collaborator

I can easily rebase, so for me it's not a problem. Not sure about @nebulon42.

@nebulon42
Copy link
Contributor

Difficult to say. There might be a few text inconsistencies now that are gone after #2597 gets merged. Assuming there is nothing in #2597 that would prevent it from being merged (I don't know yet.) it would be best to wait a bit. Just to save you from additional work if amenity-points.mss changes quite a bit. Or you could do the PR against my branch and I'll incorporate your commit then.

@matthijsmelissen
Copy link
Collaborator

I'd prefer that #2597 doesn't cause rendering changes (perhaps except for obvious bugs being fixed). So let's do first #2597 and then do the font changes at a later moment.

@kocio-pl
Copy link
Collaborator

Since both #2589 and #2597 are merged/closed now, do you plan to move on with this issue in the near future?

@sommerluk
Copy link
Collaborator Author

Yet resolved in #2730

I forgot to mention this issue in the Github description of #2730, thanks for the hint.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants