Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIve one way arrows lower precedence than names #2320

Merged
merged 1 commit into from
Sep 6, 2016
Merged

GIve one way arrows lower precedence than names #2320

merged 1 commit into from
Sep 6, 2016

Conversation

StyXman
Copy link
Contributor

@StyXman StyXman commented Aug 31, 2016

Move one way arrow rendering from several road fill related layers to roads-text-name, so arrows get lower precedence than names. As the arrow symbol is quite small, most of the time it can still be squeezed in.

Fix #2006.

…o roads-text-name, so arrows get lower precedence than names. As the arrow symbol is quite small, most of the time it can still be squeezed in.
@StyXman StyXman mentioned this pull request Aug 31, 2016
@StyXman
Copy link
Contributor Author

StyXman commented Aug 31, 2016

So it gets referenced in the issue: Fixes #2006 .

[highway = 'path'],
[highway = 'steps'],
[highway = 'track'],
[highway = 'bridleway'] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason why you changed all these filters? The feature = 'highway_*' was put in deliberately to avoid combinatorial explosion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current query for this layer does not create a feature like roads-fill and other do. Instead, it already creates a highway field. Should I port that too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think that's necessary (as long as you don't add definitions for arrows on railway's or so).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, I misread the diff.

@matthijsmelissen matthijsmelissen changed the title Fix #2006 Fix for oneway arrows preventing display of long street names Sep 1, 2016
@matthijsmelissen matthijsmelissen changed the title Fix for oneway arrows preventing display of long street names GIve one way arrows lower precedence than names Sep 1, 2016
@matthijsmelissen
Copy link
Collaborator

Thanks! I added a more descriptive title.

@pnorman
Copy link
Collaborator

pnorman commented Sep 5, 2016

Is this just waiting on a review?

@pnorman pnorman merged commit e455ee4 into gravitystorm:master Sep 6, 2016
@rickmastfan67
Copy link

Pretty big regression has been discovered when it comes to motorway/motorway_link's w/ no name at all, or just a 'ref' tag. They are now no longer getting ANY one-way arrows at any zoom. See #2340.

@StyXman
Copy link
Contributor Author

StyXman commented Sep 13, 2016

@rickmastfan67 I saw it, I'll continue the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants