-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIve one way arrows lower precedence than names #2320
Conversation
…o roads-text-name, so arrows get lower precedence than names. As the arrow symbol is quite small, most of the time it can still be squeezed in.
So it gets referenced in the issue: Fixes #2006 . |
[highway = 'path'], | ||
[highway = 'steps'], | ||
[highway = 'track'], | ||
[highway = 'bridleway'] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason why you changed all these filters? The feature = 'highway_*'
was put in deliberately to avoid combinatorial explosion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current query for this layer does not create a feature
like roads-fill
and other do. Instead, it already creates a highway
field. Should I port that too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think that's necessary (as long as you don't add definitions for arrows on railway's or so).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, I misread the diff.
Thanks! I added a more descriptive title. |
Is this just waiting on a review? |
Pretty big regression has been discovered when it comes to motorway/motorway_link's w/ no name at all, or just a 'ref' tag. They are now no longer getting ANY one-way arrows at any zoom. See #2340. |
@rickmastfan67 I saw it, I'll continue the discussion there. |
Move one way arrow rendering from several road fill related layers to
roads-text-name
, so arrows get lower precedence than names. As the arrow symbol is quite small, most of the time it can still be squeezed in.Fix #2006.