Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oneway arrows prevent display of long street names #2006

Closed
pbb72 opened this issue Dec 10, 2015 · 16 comments
Closed

Oneway arrows prevent display of long street names #2006

pbb72 opened this issue Dec 10, 2015 · 16 comments

Comments

@pbb72
Copy link

pbb72 commented Dec 10, 2015

Long street names (by the looks of it, over 20 characters long) are not displayed on oneway streets. This is especially troublesome in bilingual areas where the name in both languages is used.

See for example http://www.openstreetmap.org/way/22575474:
clipboard image 13

@matthijsmelissen
Copy link
Collaborator

I can confirm this issue as well.

Are there any places where it occurs i monolingual areas as well?

@pbb72
Copy link
Author

pbb72 commented Dec 10, 2015

Ok, it looks like the limit is a bit longer than 20 characters:
clipboard image 15

@pbb72
Copy link
Author

pbb72 commented Dec 10, 2015

Here is one example where the label is not shown on zoom 19, though it is on lower zooms: http://www.openstreetmap.org/way/7371850
clipboard image 17

@matkoniecz matkoniecz added this to the Bugs and improvements milestone Feb 27, 2016
@kdudzik
Copy link

kdudzik commented Aug 29, 2016

In my opinion it's one of the most irritating bugs, making the map useless in some areas. Street names belong to the most important names, they are essential for navigation and orientation.
Another example would be this bridge in Warsaw: the names of the bridge (except man_made=bridge) and some adjacent roads are not visible on any zoom level:
most
Mostly, the problem occurs on roads with separated directions like motorways - these are the most important roads and always one-way.
It should be quite simple to correct - either by lowering the arrows' priority or by enlarging the space between them.

@StyXman
Copy link
Contributor

StyXman commented Aug 29, 2016

I think the proper solution is to render arrows later. In my personal fork I shortened the distance between arrows (so they show earlier, important to me for driving around in unknown places) and in one way streets I get no names at all:

one_way_too_many_arrows

I will try to tackle this problem this week, make a PR.

@matthijsmelissen
Copy link
Collaborator

The question is, what is more important, the arrows or the names?

Would it be possible to avoid this problem somehow by making the arrows part of the name in the rendering?

@dieterdreist
Copy link

sent from a phone

Il giorno 29 ago 2016, alle ore 18:46, Marcos Dione [email protected] ha scritto:

In fact i think the proper solution is to render arrows later.

I would render them before, and render the name over them (because of the halo the names will still be visible)

@nebulon42
Copy link
Contributor

nebulon42 commented Aug 29, 2016

It should be quite simple to correct - either by lowering the arrows' priority or by enlarging the space between them.

@kdudzik Pull Requests are quite welcome!

@kdudzik
Copy link

kdudzik commented Aug 29, 2016

@nebulon42 in a few weeks I'll try to configure the environment and start to participate, but at the moment I can only count on others (not much time). Thanks though for the encouragement :)

@pbb72
Copy link
Author

pbb72 commented Aug 30, 2016

I think the arrows are most important, but there are many examples where names could easily have been displayed where instead several arrows are displayed on one street.

If it's a short street that doesn't have space for both an arrow and the name, then only an arrow should be shown.

If it's a long street where there is enough space for at least one arrow in addition to the name, then both should be shown.

Currently you can have very long one-way streets that don't display a name because there are too many arrows.

@StyXman
Copy link
Contributor

StyXman commented Aug 31, 2016

Well, België/Belgique/Belgien has a terrible problem, not only very long street names, but also in 2/3 languages.

In any case, I just finished moving one way arrow rendering from the tunnels, roads-fill and bridges layers to the roads-text-name layer, and it looks slightly better. It even mostly fits with what @pbb72 wants, because if the name doesn't fit, then only arrows are rendered. Of course, there is still a probability that only the name will fit.

The question is: is this move correct? Was there any particular reason to put one way arrow rendering in those layers? I'll clean up and post a PR in the afternoon.

@StyXman StyXman mentioned this issue Aug 31, 2016
@StyXman
Copy link
Contributor

StyXman commented Aug 31, 2016

PR sent, now the classical before/after images :)

z15 - included to show some pre-existing rendering diffreneces -- it seems that my fonts are different (this is a Debian Sid setup), and I have a slightly outdated database (not enough free space to keep an updatable db, sorry). Also, no bicycle or horse info.

one_way_too_many_arrows-orig-z15 |
one_way_too_many_arrows-new-z15

z16 - No bicycle info means no one way arrows in the cycleways to the sides of the tertiary at center right. At least one new name “Rue Saint-Vincent/Sint Vincentiusstraat".

one_way_too_many_arrows-orig-z16 |
one_way_too_many_arrows-new-z16

z17 - Two more: “Rustplaatslaan” and “Van Cutsem”.

one_way_too_many_arrows-orig-z17 |
one_way_too_many_arrows-new-z17

z18 - Last one. Even “Dekoster" renders names and arrows.

one_way_too_many_arrows-orig-z18 |
one_way_too_many_arrows-new-z18

@pbb72
Copy link
Author

pbb72 commented Aug 31, 2016

Looks great to me! :)

@StyXman
Copy link
Contributor

StyXman commented Aug 31, 2016

As a comparison with my previous sshot:

one_way_too_many_arrows vs
one_way_too_many_arrows-new

@pnorman
Copy link
Collaborator

pnorman commented Sep 2, 2016

Just for reference, our arrows used to be made with dasharrays until #1840. Conflicts with names wasn't brought up at the time.

@dieterdreist
Copy link

2016-09-02 10:32 GMT+02:00 Paul Norman [email protected]:

Just for reference, our arrows used to be made with dasharrays until #1840
#1840.
Conflicts with names wasn't brought up at the time.

+1, because overlap was possible. The overlap should be reenabled with the
new way of drawing arrows, rather than trying to tweak the arrow distances
or similar "tricks" to slightly improve a broken concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants