-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter small parking areas up to z17 #2171
Conversation
Is it intentional that motorcycle and bicycle parkings are not affected? |
I have not seen such problem with them on the map yet, they are much less frequent than car parkings and I don't even know the places where it could do any harm, so after some deliberation I left them unchanged. |
The example area has not good tagging. Amenity=parking is geared towards car parks. Parking along the street is tagged with parking:lane=* and if one wants to map the area of street parking the street area proposal proposes amenity=parking_space. |
I'm iffy about this, this looks like a likely case of mistagging. Trailhead parking is often very small and relevant at z17. |
Interesting. I used amenity=parking as described on wiki, for parkings of any size.
http://wiki.openstreetmap.org/wiki/Tag:amenity%3Dparking
This is for "A single parking space on a parking lot" (though wiki has also contradictory "use capacity=* to define the number of parking spaces it represents"). https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dparking_space |
OK, now on wiki I see "For parking spaces along streets see parking:lane=*.". |
@jojo4u This can be a problem with tagging, but I'm not sure what tag would be proper. For example this one (from Poznan example): http://www.openstreetmap.org/way/421652588 is definitely not a parking:lane=* (which BTW is rather just a property of the road, not a standalone tag) - it's a special, small parking area separated by grass, not a general lane on the street. The difference between amenity=parking_space vs amenity=parking is not clear (it probably is about part of the parking - like marked row of places - and there's no restriction on lowest parking size or location). We were discussing it on polish forum, but came with no clear output (@matkoniecz was active there): http://forum.openstreetmap.org/viewtopic.php?id=53727 There are also specially marked parts of the street (not a lane) or even crossing the line between a road and footway area or service roads with some wider parts where the cars stay with no clear marking. It makes a problem of parking tagging complicated, so it's hard for me to say it's "mistagging". @pnorman I guess "trailhead parking" means a parking near the trail start/entry for tourists? I don't want to get rid of the area color, only the letter. This is probably another case of a more general problem that outside the residential areas every amenity is more important and should be rendered earlier or stronger. |
I agree dropping parking from z17 likely causes more problems than it solves. Thanks for the suggestion though @kocio-pl! |
If I got it right now in the code rendering of parking letter has been dropped altogether from z17? I like the idea from kocio more where we differentiate among small and large parking spaces so we still may render parkings on z17. If parking letter on large parkings is dropped than casual viewer might have harder time to differentiate that yellow space form amenities visible in the same color. In less tagged areas one might wonder if that is stadium or school just without pitch area or building being drawn on the map. |
Currently we are filtering "P" letters if the parking area is too small (https://github.com/gravitystorm/openstreetmap-carto/blob/master/amenity-points.mss#L313). But from z17 we render them unconditionally (https://github.com/gravitystorm/openstreetmap-carto/blob/master/amenity-points.mss#L1042).
Unfortunately this is too early, since without filtering there are some small parkings, where we render bigger "P" than the area and create clutter. I think we should use filtering also on z17, because on z18 the letter will probably always fit inside the area, which is a good rule of thumb IMO.
BTW: I guess both parking-related sections could be close to each other to make this code more clear.
Warsaw, z17


before
after
Poznan, z17


before
after