Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle inspection #2096

Closed
wants to merge 2 commits into from
Closed

Conversation

Stalfur
Copy link

@Stalfur Stalfur commented Mar 24, 2016

Added rendering for currently non-rendered amenity=vehicle_inspection.
Noticed a rising trend in people using shop=car for anything car related in order to be rendered, devaluing data accuracy.
Yearly vehicle inspection is mandatory in EU and EFTA countries and in other countries as well.
The changes are basically to add amenity=vehicle_inspection to be rendered alongside other amenities, using shop=car icon but rendered in amenity brown instead of shop purple.

Preview of icon (area: http://www.openstreetmap.org/#map=19/64.10542/-21.86522 )
vehicle_inspection_preview

Stalfur added 2 commits March 24, 2016 13:56
EU and EFTA countries have yearly inspections. A preset is being added
in iD editor. In general people are marking anything car related as
shop=car in order for anything to render, devaluing data accuracy. This
uses the generic car from shop=car but uses amenity brown instead of
shop purple.
YAML and MML changes
@Stalfur
Copy link
Author

Stalfur commented Mar 24, 2016

Hmmm. I did run ./scripts/yaml2mml.py .

@kocio-pl
Copy link
Collaborator

I think they could be rendered rather like shop=car_repair (#1778), since I guess this is just a special kind of such shops.

@SomeoneElseOSM
Copy link
Contributor

There's probably a tagging discussion to be had elsewhere, but it's worth mentioning in passing that in some countries there's a substantial subset of such places that are "check" but not "repair". See for example:

https://help.openstreetmap.org/questions/33229/how-to-tag-a-smog-check-center-only-in-america

@dieterdreist
Copy link

sent from a phone

Am 24.03.2016 um 15:23 schrieb Jóhannes Birgir Jensson [email protected]:

The changes are basically to add amenity=vehicle_inspection to be rendered alongside other amenities, using shop=car icon but rendered in amenity brown instead of shop purple.

the proposal for this tag is still in draft status. This tag works in some context (standalone vehicle inspection place) but not in others (where it is an attribute, a service offered besides others), and there wasn't any discussion about this AFAIK.

@dieterdreist
Copy link

sent from a phone

Am 24.03.2016 um 15:42 schrieb kocio-pl [email protected]:

I think they could be rendered rather like shop=car_repair (#1778), since I guess this is just a special kind of such shops.

sometimes it is, sometimes not, might be country specific. There are car repairs certified to do it, but there are also stand alone businesses that only do vehicle inspection.

@matthijsmelissen
Copy link
Collaborator

In Luxembourg, and likely some other countries as well, vehicle inspection is done exclusively by the government. Those governmental vehicle inspection stations (obviously) don't do repairs.

@kocio-pl
Copy link
Collaborator

Leaving aside discussions about tagging scheme itself, I don't have a strong opinion on the symbol, though probably such entity uses similar tools as in car repair shop, so I slightly prefer this icon.

@Stalfur
Copy link
Author

Stalfur commented Mar 24, 2016

In Iceland these used to be government run and only did inspections. This was privatized and currently 3 companies run these inspections. None of those does repairs hence my choice of icon not being the repair icon. @kocio-pl I haven't seen any of them use a wrench, they mostly use their hands, light calibration devices, "break rollers", emission hoses and flashlights.

As for tag status and draft mode - there is no gold standard yet in OSM is there....
A full shakeup of car related services might be warranted though, having everything tagged as shop=car is not helpful.

@kocio-pl
Copy link
Collaborator

So maybe the flashlight (or even the eye!) instead of wrench?

@Stalfur
Copy link
Author

Stalfur commented Mar 24, 2016

Flashlight would be my choice

@HolgerJeromin
Copy link
Contributor

Or a magnifier

@Stalfur
Copy link
Author

Stalfur commented Mar 24, 2016

Yeah, flashlight, magnifier would both work. The eye is a bit Orwellian...

@pnorman
Copy link
Collaborator

pnorman commented Mar 24, 2016

806 uses seems insufficient for a general-purpose rendering.

@Stalfur
Copy link
Author

Stalfur commented Mar 24, 2016

Without support in editors this has not been widely tagged. Adding them in iD for example requires me to make a point and filling in values by hand (I'm preparing a pull request for that, have already created values in my branch of iD) - for a seasoned mapper this is not a problem but for new ones it is.

In making it easier to enter these into iD we will be making sure more will be added.

Also as a legal requirement it is an obligatory stop for car owners every year (and their trailers etc), as many other official in nature institutes (or privately run entities that fullfill the legal requirements on authority of the state) they are few in numbers.

The importance is not tied to numbers always, embassies for example are few (7200) compared to car shops (62.000) but we render them for their importance, not numbers.

This is a typical chicken and egg problem. Without editor support it will not be added, without rendering support it will be added incorrectly (shop=car or shop=car_repair) in order to show up on the map (tagging for renderer). Making sure it shows up on map (in highest zooms) and is available in editors it will grow far better than otherwise.

@matkoniecz
Copy link
Contributor

Without editor support it will not be added

It is a good idea to propose rendering in editors/including in tagging preset/validator rule before proposing rendering in map styles (editors are more inclusive and their map style is much closer to "show everything").

@pnorman pnorman closed this Mar 25, 2016
@matkoniecz
Copy link
Contributor

Also, it would be better to create new issue and wait for reaction before making PR (or in that case - requesting #881 to be reopened). At least I prefer doing it this way.

806 uses seems insufficient for a general-purpose rendering.

I agree, especially as tag is without editor support. Either because nobody noticed it - in that case just make request and it will be likely to be added, maybe follow with PR if maintainers are busy with other things. Other possibility is that it was rejected by JOSM/iD/other editors for some reasons (controversial, bad tagging scheme...) in that case it is rather poor idea to include it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants