Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing color of shop=car_repair to brown #1778

Merged
merged 1 commit into from
Sep 18, 2015

Conversation

kocio-pl
Copy link
Collaborator

As mentioned in #1777: shop=car_repair is in fact amenity, so it should be rendered in brown, since it sells services rather than goods:

car_repair-brown-19

@matkoniecz
Copy link
Contributor

Seems like a good idea.

@matthijsmelissen
Copy link
Collaborator

Under the same logic, hairdresser should be brown too. Not sure if I agree.

@kocio-pl
Copy link
Collaborator Author

Right, thanks for noticing! We have some fundamental ambiguity here (how shop differs from amenity), so I will resort to Tagging to discuss it a bit first.

@matkoniecz
Copy link
Contributor

I am not sure whatever this belongs on tagging - in that case tagging is clear, problem is with murky distinction in using brown and purple in this style (for some cases it is clear, for some it gets problematic).

@kocio-pl
Copy link
Collaborator Author

For me this alone would be a minor issue, but tagging amenity=car_wash while at the same time having also shop=car_repair is not "clear". It indicates lack of general understanding what are really those categories, because I can't find the rule why one is considered to be a shop and the other one an amenity. Hairdresser/beauty shop is also interesting in this regard.

@kocio-pl
Copy link
Collaborator Author

@gravitystorm
Copy link
Owner

It indicates lack of general understanding what are really those categories,

You can think of the tags as opaque key/value pairs. It's not important which are amenity= and which are shop=. It is left to the editors and renderers to create whichever categories they think are useful - especially important, since there is not a One True Way to categorise the world!

So the discussion that happens here - how we want to display the features - is independent of both the precise tags that are used, and also independent of any discussion on the tagging mailing list. We should chose an answer based on our own considerations - colour, icon style etc, as well as how many categories we think is appropriate and what those categories should be.

@kocio-pl
Copy link
Collaborator Author

The discussion on Tagging has helped me understand the problem deeper, see my conclusions here: #1783. In a nutshell: we can rely on the tagging system as a base for our colors if we think it's useful, but we can also create our own color classification (which I prefer).

@dieterdreist
Copy link

sent from a phone

Am 24.08.2015 um 14:53 schrieb Andy Allan [email protected]:

You can think of the tags as opaque key/value pairs. It's not important which are amenity= and which are shop=.
It is left to the editors and renderers to create whichever categories they think are useful - especially important, since there is not a One True Way to categorise the world!

while it is true that there are multiple ways to look at the world, I don't agree that keys are completely arbitrary (or should be completely arbitrary). Just because there are more ways to categorize the world does not mean there shouldn't be a concept/inherent logic behind the tags we use, or in other words, there should be a defined way we deliberately choose to make up our categories.

Of course this doesn't mean this map style or any other map style then does have to follow the same system - just to have a system (at all) will help contributors to find/choose the right tags and to introduce new tags for stuff that wasn't tagged so far.

@matkoniecz
Copy link
Contributor

Under the same logic, hairdresser should be brown too. Not sure if I agree.

I would not oppose making hairdresser brown. It is a bit surprising but it makes sense (and I seem to remember my surprise that hairdresser icon has shop colour).

@kocio-pl
Copy link
Collaborator Author

I still remember how I was surprised that hairdresser tag value is classified under the shop namespace!

I like the POI coloring system to be like this:

  1. Violet for buying goods.
  2. Brown for general services (paid or not).
  3. Black for undecided/general things.

Of course there can be some more specific categories (I like pink for anything health-related and light blue for transportation) or exceptions (I rather see the fountain as a water-related blue than amenity brown), but repairs (like car_repair and electronics_repair) or services mainly (like hairdresser) should be brown IMO (and a wig shop in violet, of course).

matkoniecz added a commit that referenced this pull request Sep 18, 2015
Changing color of shop=car_repair to brown
@matkoniecz matkoniecz merged commit 799d308 into gravitystorm:master Sep 18, 2015
@kocio-pl kocio-pl deleted the car_repair-brown branch September 19, 2015 08:30
@kocio-pl kocio-pl mentioned this pull request Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants