Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding amenity=ferry_terminal icon #1673

Closed
wants to merge 1 commit into from

Conversation

kocio-pl
Copy link
Collaborator

Resolves #869.

Rendered like bus stop - z=16:
ferry-z16

z>=17 (with osmic icon):
ferry-z17-osmic

@kocio-pl
Copy link
Collaborator Author

Edited version, based on osmic with top inspired by MapQuest Open icon (both are too solid and look rather like bollard for me):
ferry-z17-my-turkawka
ferry-z17-my-pliszka

@imagico
Copy link
Collaborator

imagico commented Jul 22, 2015

I don't think there is a gain from adding a large specific symbol for this purpose. The meaning is perfectly clear with just a generic square symbol which uses less space and adds less clutter to the map.

@matkoniecz
Copy link
Contributor

Yes, especially that symbol is not really recognisable. Generic square seems much better.

@kocio-pl
Copy link
Collaborator Author

Hm, you may be right. However I'd like to hear if there are some counterexamples, where just the dot with label would be suboptimal choice maybe?

@matthijsmelissen
Copy link
Collaborator

At larger terminals, such as here, it might not always be immediately clear which building is the ferry terminal.

@kocio-pl
Copy link
Collaborator Author

So maybe we should show this icon just for areas? Or maybe push it even deeper into z18+ or z19+?

@ximex
Copy link

ximex commented Jul 23, 2015

the icon itself looks good.

@matthijsmelissen
Copy link
Collaborator

Is is not possible to come up with a simpler symbol for 'ship'? The 'terminal' concept will be clear enough from the ship, I think.

@kocio-pl
Copy link
Collaborator Author

Any ideas are welcome. How should it look like?

I can also split this PR into generic blue square part, which is not controversial, and we can add the icon later, once there is one drawn and approved.

@matkoniecz
Copy link
Contributor

I think that splitting is a good idea.

@pnorman
Copy link
Collaborator

pnorman commented Jul 27, 2015

Not sure how well it works - it can't always be distinguished from a bus stop

image

Remember, the marked points are not on the water's edge.

See for example, Tsawwassen. Now, this should probably be an area, but the centroid of the area isn't going to be at the coastline either.

Sidney International is an area, as are Swartz Bay and Langdale.

A ferry icon is useful at lower zooms to show where the terminal is, but at high zooms its pretty eident where the road meets the water. If we wanted an icon there, we should do it based on where the lines touch, not ferry terminals, which are different.

@kocio-pl
Copy link
Collaborator Author

I guess the best choice for terminal icon could be something like what we will shortly use for the ford: just the water and the arrows for showing there is a way over it. However the question is if we want to distinguish those icons, and if yes - in what way should they be different?

@kocio-pl kocio-pl mentioned this pull request Jul 27, 2015
@kocio-pl
Copy link
Collaborator Author

What about simpler shape like this:
ferry-arrows

@matkoniecz
Copy link
Contributor

How it works for places from #1673 (comment) ?

@kocio-pl
Copy link
Collaborator Author

Sidney:
ferry-arrows-sidney

Swartz Bay:
ferry-swartz

Langdale:
ferry-langdale

Tsawwassen node is overcrowded with tags (ferry_terminal+locality+traffic_signals), so not suitable for testing this icon.

@kocio-pl
Copy link
Collaborator Author

Maybe we should use the aeroway color for ferry terminal areas too. I guess this might be even used for all the transport terminals (like bus stations).

@sabas
Copy link

sabas commented Aug 14, 2015

Rendering the area could be useful.
Should the single berthing points inside the terminal be tagged differently?
Sample area http://overpass-turbo.eu/s/aW6

@jojo4u
Copy link

jojo4u commented Aug 14, 2015

@sabas From what I understand on a complex facility amenity=ferry_terminal should be the whole area (buildings, parking spaces), This extends the meaning ferry_terminal a bit but in 2007 there was not so much hindsight (http://wiki.openstreetmap.org/wiki/Talk:Proposed_features/Ferry_Terminal)

EDIT: mooring=ferry is not defined for nodes. So the usual approach seems to be to just end the ferry route on a pier and optionally mark the pier with mooring=ferry.

@jojo4u
Copy link

jojo4u commented Aug 14, 2015

@kocio-pl I improved Tsawwassen.
The other examples suffer from "too much highway=service", something I already fixed on Tsawwassen and will be on Swartz Bay (https://www.openstreetmap.org/note/393069)

@kocio-pl
Copy link
Collaborator Author

First I will have to learn how to tag the airport, then find out what parts ferry terminal consists of, and in the end try to find some analogies. It would be also good to study bus and railway station - or maybe also other transportation stations, to be as universal as possible. However I'm not into transportation too much and try to do few other things, so the help would be welcome.

I just thought it would be dead easy task... =}

@matkoniecz
Copy link
Contributor

Unfortunately in current state it is not ready for merge and it seems unlikely to change in the near future - so I will close it for now.

Updated/new PRs solving this problem are welcomed!

I just thought it would be dead easy task... =}

Almost everything is harder than it seems before starting it.

@matkoniecz matkoniecz closed this Sep 16, 2015
@kocio-pl
Copy link
Collaborator Author

Sure, currently I plan to start with defining airport/heliport/ferry(port) as a similar big areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants