-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move memorial icon to SVG #1241
Conversation
Tester recognizes neither before nor after. I'm not sure if this should rendered significantly/on low zoomlevels at all. Some mrmorials are significant landmarks, but others are very minor compared to yhe surroundings. |
I think the new icon is an improvement - but the basic idea of the icon needs revisiting, as in my experience it's not clear what it means. |
yes, the icon is good, but especially the german "Stolpersteine" are much too prominent. |
Prominence: Agreed, but the icon is now smaller although sharper. This needs adressing by categorising using other tags. Other icon: I thought about this a bit and it is hard to come up with something distinctive for memorial. The idea of depiciting a plate or stone with text on it is not so bad. Sometimes this are statues, but depiciting e.g. a head would not include all the other possibilities of memorial. The other icon I meant to use for monument (monument-16.svg) might imply a larger structure. |
Regarding the icon itself: 👍 Regarding previous comments: I very much agree with @math1985 and @nebulon42
As many other features, it would be great to have subtags and established rules (tiers for zoom threshold and rendering) so that:
|
Sooner or later we will need the subtags rendering - memorial table and memorial cemetery are very different beasts. |
Memorial rendering clearly has issues, but at least everyone agrees that the new icon is an improvement, so I don't mind merging this. |
Implements part of #1165.
Icon: nebulon42/osmic/memorial-16.svg
before
after