Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move memorial icon to SVG #1241

Merged
merged 1 commit into from
Jan 24, 2015

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.
Icon: nebulon42/osmic/memorial-16.svg

before
memorial_before

after
memorial_after

@nebulon42 nebulon42 mentioned this pull request Jan 18, 2015
66 tasks
@matthijsmelissen
Copy link
Collaborator

Tester recognizes neither before nor after.

I'm not sure if this should rendered significantly/on low zoomlevels at all. Some mrmorials are significant landmarks, but others are very minor compared to yhe surroundings.

@pnorman
Copy link
Collaborator

pnorman commented Jan 18, 2015

I think the new icon is an improvement - but the basic idea of the icon needs revisiting, as in my experience it's not clear what it means.

@HolgerJeromin
Copy link
Contributor

yes, the icon is good, but especially the german "Stolpersteine" are much too prominent.

@nebulon42
Copy link
Contributor Author

Prominence: Agreed, but the icon is now smaller although sharper. This needs adressing by categorising using other tags.

Other icon: I thought about this a bit and it is hard to come up with something distinctive for memorial. The idea of depiciting a plate or stone with text on it is not so bad. Sometimes this are statues, but depiciting e.g. a head would not include all the other possibilities of memorial. The other icon I meant to use for monument (monument-16.svg) might imply a larger structure.

@althio
Copy link

althio commented Jan 19, 2015

Regarding the icon itself: 👍

Regarding previous comments: I very much agree with @math1985 and @nebulon42

I'm not sure if this should rendered significantly/on low zoomlevels at all. Some mrmorials are significant landmarks, but others are very minor compared to yhe surroundings.
Prominence: [...] This needs adressing by categorising using other tags.

As many other features, it would be great to have subtags and established rules (tiers for zoom threshold and rendering) so that:

  • first tier: important/landmark/monumental features are rendered early (z16?) and maybe special rendering when second tier appears (slightly larger icon size? icon in square/circle?)
  • second tier: common features are rendered at closer zoom levels (z18?)
  • negligible features are not rendered or only a maximal zoom level and maybe special rendering (lighter as in private POI?).

@polarbearing
Copy link
Contributor

@althio - would be good, but apparently (see #1066) subtags are not yet supported.
If the monumental features are tagged as monument they could get a different icon as proposed in #758.

@kocio-pl
Copy link
Collaborator

Sooner or later we will need the subtags rendering - memorial table and memorial cemetery are very different beasts.

@matthijsmelissen
Copy link
Collaborator

Memorial rendering clearly has issues, but at least everyone agrees that the new icon is an improvement, so I don't mind merging this.

@matthijsmelissen matthijsmelissen merged commit 1e95795 into gravitystorm:master Jan 24, 2015
@nebulon42 nebulon42 deleted the svg-memorial branch January 24, 2015 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants