Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render memorial:type=stolperstein only in z19 #1066

Closed
tilmanb opened this issue Oct 15, 2014 · 19 comments
Closed

Render memorial:type=stolperstein only in z19 #1066

tilmanb opened this issue Oct 15, 2014 · 19 comments

Comments

@tilmanb
Copy link

tilmanb commented Oct 15, 2014

There are lots[0] of "Stolpersteine"[1] in the OSM data. Each Stolperstein is a memorial for one or more persons deported and killed by the nazi regime.

The number of Stolpersteine is huge, and they someplace[2] clutter the map output at z18.

This has lead to users deleting them "for simplicity's sake" and to "clean up the map". This is unacceptable, of course, but the problem of map clutter remains.

So i propose to render features tagged with

historic=memorial
memorial:type=stolperstein

only at z19.

[0] 12567 nodes as of this writing, see http://taginfo.openstreetmap.org/tags/memorial%3Atype=stolperstein
[1] https://en.wikipedia.org/wiki/Stolperstein
[2] http://www.openstreetmap.org/#map=18/50.12166/8.68692

@matkoniecz matkoniecz added this to the 3.x - Needs upgrade to mapnik or openstreetmap-carto.style milestone Oct 15, 2014
@matkoniecz
Copy link
Contributor

Unfortunately memorial:type is not available in the database (see https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.style), so it can not be easily done.

EDIT: memorial tag is also not available.

@mboeringa
Copy link

Unfortunately memorial:type is not available in the database (see https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.style), so it can not be easily done.

Also unfortunate is, that there are two tagging schemes. It is the classic discussion that seems to come up each time refinement of a tag is needed by a "type" specification: use the A:type=x namespace or simply use A=x instead...

The historic=memorial Wiki page warns against using memorial:type=x, and use memorial=x instead. However, the "memorial:type" Wiki page is better layed out than just "memorial", and in practice, TagInfo shows memorial:type to be more often used:

http://wiki.openstreetmap.org/wiki/Tag:historic%3Dmemorial
http://wiki.openstreetmap.org/wiki/Key:memorial:type
http://wiki.openstreetmap.org/wiki/Key:memorial

Also see the Talk page, which is inconclusive about this distinction:
http://wiki.openstreetmap.org/wiki/Talk:Tag:historic%3Dmemorial

@wambacher
Copy link

try tags ? 'memorial' and tags->'memorial:type' because all tags should be in the database (if tags are importetd).

@dieterdreist
Copy link

2014-10-16 17:03 GMT+02:00 wambacher [email protected]:

try tags ? 'memorial' and tags->'memorial:type' because all tags should be
in the database (if tags are importetd).

no, there are no hstore columns in the carto style db for the mapnik style
(english). I think you are confusing this with the German style (mapnik:de).

@pnorman
Copy link
Collaborator

pnorman commented Dec 15, 2016

👎 to memorial:type=stolperstein. The usage of it is too country-specific. I'd be more open to memorial=plaque along with the other memorial subkeys, but usage isn't great.

@dieterdreist
Copy link

dieterdreist commented Dec 15, 2016 via email

@imagico
Copy link
Collaborator

imagico commented Dec 15, 2016

We aim to support generic tagging. memorial:type=stolperstein on the other hand is highly specialized. If memorial=plaque (3617 uses) and memorial:type=plaque(476 uses) are rendered this could be considered but otherwise it would support incorrect tagging.

Note the fact that we have competing memorial=* and memorial:type=* is in itself an issue.

@matthijsmelissen
Copy link
Collaborator

The usage of it is too country-specific.

There are stolpersteinen in 18 different countries now.

However, I agree usage is too specialized. Not too mention that there are Stolpersteinen every couple of houses in some German cities.

@dieterdreist
Copy link

dieterdreist commented Dec 15, 2016 via email

@dieterdreist
Copy link

dieterdreist commented Dec 15, 2016 via email

@matthijsmelissen
Copy link
Collaborator

You're right, I didn't read well.

@pnorman
Copy link
Collaborator

pnorman commented Dec 15, 2016

memorial:type=stolperstein on the other hand is highly specialized

Yes, and I'd like to avoid using it for that reason, even if it's to exclude rendering instead of rendering a specific feature.

I'd be fine with adjusting rendering based on memorial=plaque, although the usage might not be there.

@dieterdreist
Copy link

dieterdreist commented Dec 15, 2016 via email

@pnorman
Copy link
Collaborator

pnorman commented Dec 15, 2016

what has this to do with this issue? Are you suggesting people should
change tagging from memorial:type=stolperstein to memorial=plaque? Why do
you favor the "memorial" key if the "memorial:type" key is used more often?

The memorial key is mentioned earlier in this issue, and is much more widely used.

@dieterdreist
Copy link

what do you base this on? I'm relying on taginfo and the current relation is 45% "memorial" vs. 55% memorial:type.

Can you please answer the question whether you are suggesting people should change tagging from memorial:type=stolperstein to memorial=plaque in order to account for it in the rendering? Thank you.

@kocio-pl
Copy link
Collaborator

This ticket is exactly what I'd like to do with plates - render them only on z19 and using smaller and more appropriate icon. It's about making them less visible than standard and this memorial type fits this conception perfectly.

@HolgerJeromin
Copy link
Contributor

I am surprised to see that the Stolperstein plaques were not handled in #2689.

Did i missed a discussion about that?

Should we communicate (tagging ML, Wiki) that a stolperstein should have
historic=memorial
memorial:type=stolperstein
plus a "new" memorial=plaque.
The better rendering for that would promote this additional tag.

This would be a good thing IMO as this would reduce special casing for all osm data consumers.

@kocio-pl
Copy link
Collaborator

I'm not sure what's the right way to deal with it, so I took a conservative approach. Stolperstein and blue_plaque are similar cases, so it should be good to unify their tagging somehow.

@kocio-pl
Copy link
Collaborator

Until some progress or discussion about tagging these types will occur, I think we should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants