Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some road labels miss halos #515

Closed
Zverik opened this issue May 7, 2014 · 7 comments · Fixed by #812
Closed

Some road labels miss halos #515

Zverik opened this issue May 7, 2014 · 7 comments · Fixed by #812
Labels
roads

Comments

@Zverik
Copy link
Contributor

Zverik commented May 7, 2014

Look here (disregard fake 3d buildings). Labels for tracks are missing halo, which makes reading them hard. It seems secondary labels also miss it: when overlapping an oneway arrow, the name is hardly readable.
@RobJN
Copy link

RobJN commented May 7, 2014

What the... Disregard the 3D buildings!! That's crazy and easily the most extreme case of tagging for the renderer I have ever seen.

@pnorman
Copy link
Collaborator

pnorman commented May 8, 2014

Some road labels miss halos

What road labels have halos?

@Zverik
Copy link
Contributor Author

Zverik commented May 8, 2014

I think they had halos before. At least track labels.

@Klumbumbus
Copy link

tracks had halo before. see here and move the drag button http://bl.ocks.org/tyrasd/raw/6164696/#16.00/50.7018/12.9152

@Klumbumbus
Copy link

For tracks this will be solved by #748

@nighto
Copy link
Contributor

nighto commented Jul 21, 2014

I must confess I'm very curious to see what did they look like before. Does anyone took a screenshot?

@matthijsmelissen
Copy link
Collaborator

@nighto You can compare 'before' and 'after' at the site @Klumbumbus linked to.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Aug 2, 2014
@matthijsmelissen
Clean up highway labels
4f33212 
* Make font sizes more consistent (resolves gravitystorm#544)
* Let tertiary labels start at z14 rather than z15 (resolves gravitystorm#301)
* Add label for bridleways
* Remove halo from residential/unclassified/road (resolves gravitystorm#515)
* General code clean-up
@matthijsmelissen matthijsmelissen mentioned this issue Aug 2, 2014
Merged
@matkoniecz matkoniecz mentioned this issue Oct 5, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
roads
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up highway labels matthijsmelissen/openstreetmap-carto
6 participants
@nighto @Zverik @pnorman @RobJN @matthijsmelissen @Klumbumbus