[v8] Conditionally publish deb packages #9783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadells
requested review from
michaelmcallister,
tcsc,
russjones,
zmb3 and
fheinecke
russjones
approved these changes
Jan 19, 2022
zmb3
approved these changes
Jan 19, 2022
This patch makes a couple changes:
1. deb archives are not published to apt if they're not the latest
release ever
2. both rpm and deb archives are no longer published to yum / apt if
they contain any pre-release indicator or build metadata
3. nothing is published if the commit isn't tagged.
Contributes to #8166
(cherry picked from commit 8540533)
wadells
added a commit
that referenced
this pull request
Feb 23, 2022
This was removed in #9783, and should not have been.
wadells
added a commit
that referenced
this pull request
Feb 24, 2022
wadells
added a commit
that referenced
this pull request
Feb 24, 2022
This was removed in #9783, and should not have been.
wadells
added a commit
that referenced
this pull request
Feb 25, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8 backport of #9496
Summary:
This patch makes a couple changes:
Contributes to #8166
(cherry picked from commit 8540533)
Testing Done
No further testing beyond what I did for #9496.
Notes
This does not need to be ported further back than v8 because we have a simpler strategy in 7.0 (#9237), 6.2 (#9238), and 5.0 (#9239). We might benefit from porting
Check if commit is taggedandCheck if tag is prereleasefurther, as we have seen some pre-releases slip into the RPM repo in 6.2. They're harmless as far as I know.