Remove CI-specific UID/GID to appease GH's breaking change #50176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred Heinecke <[email protected]>
fheinecke
added
backport-required
no-changelog
doggydogworld
approved these changes
Dec 12, 2024
camscale
approved these changes
Dec 12, 2024
Signed-off-by: Fred Heinecke <[email protected]>
r0mant
approved these changes
Dec 12, 2024
public-teleport-github-review-bot
bot
removed request for
gzdunek and
fspmarshall
|
@fheinecke See the table below for backport results.
|
This was referenced Dec 12, 2024
ravicious
reviewed
Dec 13, 2024
There was a problem hiding this comment.
I think this might've broken TestRootX11ForwardPermissions on v15. It failed for me twice in a row.
sshserver_test.go:1098:
Error Trace: /__w/teleport/teleport/lib/srv/regular/sshserver_test.go:1098
Error: Received unexpected error:
user: unknown userid 1000
Test: TestRootX11ForwardPermissions
https://github.com/gravitational/teleport/actions/runs/12315623784/job/34374219868#step:6:1942
https://github.com/gravitational/teleport/actions/runs/12315086928/job/34372541318#step:6:1943
#49992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub unexpectedly made a breaking change to the
runneruser used in GHA pipelines. This works around the issue by removing the hard-coded uid/gid values in our makefile.There is a reasonable chance that this will break some workflow, but it should get our Go security release out the door.
Passing build: https://github.com/gravitational/teleport.e/actions/runs/12304943632/job/34343525931 (failures are due to apple notarization service)
Refs: