[v15] Refactor how tsh lists apps as text #49992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way it's going to be easier to add a column with target ports, which should be displayed only if the list includes multi-port apps. Conflicts: tool/tsh/common/app_test.go tool/tsh/common/tsh.go
ravicious
added
the
no-changelog
github-actions
bot
added
backport
size/md
tsh
This comment was marked as off-topic.
This comment was marked as off-topic.
Joerger
approved these changes
Dec 11, 2024
strideynet
approved these changes
Dec 13, 2024
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #49505
Manual backport because of conflicts in both files, mostly due to the fact that on v15 certain tsh functions don't accept
io.Writeras an argument.