[v17] Bump the electron group with 2 updates #50144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump the electron group with 2 updates Bumps the electron group with 2 updates: [electron](https://github.com/electron/electron) and [electron-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-builder). Updates `electron` from 33.1.0 to 33.2.1 - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v33.1.0...v33.2.1) Updates `electron-builder` from 25.1.7 to 25.1.8 - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/[email protected]/packages/electron-builder) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development update-type: version-update:semver-minor dependency-group: electron - dependency-name: electron-builder dependency-type: direct:development update-type: version-update:semver-patch dependency-group: electron ... Signed-off-by: dependabot[bot] <[email protected]> * Turn off electron-builder's notarization * Add console.log to notarize.js Otherwise the output during a build would just say this: > skipped macOS notarization reason=`notarize` options were set explicitly `false` which could give the wrong impression that notarization was not done at all. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rafał Cieślak <[email protected]>
ravicious
added
the
no-changelog
avatus
approved these changes
Dec 12, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
tigrato
approved these changes
Dec 12, 2024
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
fheinecke
added a commit
that referenced
this pull request
Dec 12, 2024
This reverts commit 761f4c8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #49610, #50129.