Fix electron-builder peer deps #50129
Merged
+13
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
the
no-changelog
gzdunek
approved these changes
Dec 12, 2024
avatus
approved these changes
Dec 12, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#49610 bumped electron-builder, but that package still has peer deps specified in a weird, I think even recursive way, that neither yarn nor pnpm seem to be able to handle properly.
As a result, app-builder-lib wasn't properly resolved to 25.1.8, instead it stayed at 25.1.7. This results in a warning when running
pnpm installthat app-builder-lib has an unmet peer dep.I solved this manually by adding app-builder-lib and electron-builder-squirrel-windows to teleterm's package.json, doing pnpm install, and then removing the entries from package.json. Then I re-run pnpm install to verify that everything is correct.