[v13] Respect [HTTP(S)|NO]_PROXY envs when dialing directly to Kube
#30615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Respect `[HTTP(S)|NO]_PROXY` envs when dialing directly to Kube PR #11257 disabled support of `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY` environement flags for Kubernetes Access. The desired behavior was expected to be respected only by the Kubernetes Proxy and Kubernetes Legacy Proxy when dialing over reverse tunnel but ended up applied to all outbound connections from Kube Access flow. This PR enables support for proxy env's when dialing directly to the Kubernetes Cluster - `kubernetes_service` and `legacy_proxy` when the cluster is local. Fixes #30550 Signed-off-by: Tiago Silva <[email protected]> * fix func name * fix comment --------- Signed-off-by: Tiago Silva <[email protected]>
webvictim
approved these changes
Aug 17, 2023
AntonAM
approved these changes
Aug 17, 2023
smallinsky
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #30583 to branch/v13