Don't respect HTTP_PROXY env in k8 forwarder #11257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
reviewed
Mar 18, 2022
There was a problem hiding this comment.
@smallinsky This definitely needs test coverage, I can imagine this can easily regress again.
smallinsky
requested review from
r0mant
and removed request for
timothyb89 and
greedy52
|
Added UT regression. |
smallinsky
force-pushed
the
smallinsky/kube-fwd-switch-to-x-net-http2
branch
from
8da79e9 to
5f6f8b6
Compare
NajiObeid
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
All good on my side. But I personally would have preferred to see this part of the kube h2 integration tests. You know to be less reliant on mocks or testing edge cases, but more along the lines of testing different setups clients might have as weird as they can get.
r0mant
approved these changes
Mar 22, 2022
smallinsky
added a commit
that referenced
this pull request
Mar 25, 2022
smallinsky
added a commit
that referenced
this pull request
Mar 29, 2022
Closed
Closed
tigrato
added a commit
that referenced
this pull request
Aug 16, 2023
PR #11257 disabled support of `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY` environement flags for Kubernetes Access. The desired behavior was expected to be respected only by the Kubernetes Proxy and Kubernetes Legacy Proxy when dialing over reverse tunnel but ended up applied to all outbound connections from Kube Access flow. This PR enables support for proxy env's when dialing directly to the Kubernetes Cluster - `kubernetes_service` and `legacy_proxy` when the cluster is local. Fixes #30550 Signed-off-by: Tiago Silva <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Respect `[HTTP(S)|NO]_PROXY` envs when dialing directly to Kube PR #11257 disabled support of `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY` environement flags for Kubernetes Access. The desired behavior was expected to be respected only by the Kubernetes Proxy and Kubernetes Legacy Proxy when dialing over reverse tunnel but ended up applied to all outbound connections from Kube Access flow. This PR enables support for proxy env's when dialing directly to the Kubernetes Cluster - `kubernetes_service` and `legacy_proxy` when the cluster is local. Fixes #30550 Signed-off-by: Tiago Silva <[email protected]> * fix func name * fix comment --------- Signed-off-by: Tiago Silva <[email protected]>
tigrato
added a commit
that referenced
this pull request
Aug 17, 2023
* Respect `[HTTP(S)|NO]_PROXY` envs when dialing directly to Kube PR #11257 disabled support of `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY` environement flags for Kubernetes Access. The desired behavior was expected to be respected only by the Kubernetes Proxy and Kubernetes Legacy Proxy when dialing over reverse tunnel but ended up applied to all outbound connections from Kube Access flow. This PR enables support for proxy env's when dialing directly to the Kubernetes Cluster - `kubernetes_service` and `legacy_proxy` when the cluster is local. Fixes #30550 Signed-off-by: Tiago Silva <[email protected]> * fix func name * fix comment --------- Signed-off-by: Tiago Silva <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
…) (#30615) * Respect `[HTTP(S)|NO]_PROXY` envs when dialing directly to Kube PR #11257 disabled support of `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY` environement flags for Kubernetes Access. The desired behavior was expected to be respected only by the Kubernetes Proxy and Kubernetes Legacy Proxy when dialing over reverse tunnel but ended up applied to all outbound connections from Kube Access flow. This PR enables support for proxy env's when dialing directly to the Kubernetes Cluster - `kubernetes_service` and `legacy_proxy` when the cluster is local. Fixes #30550 * fix func name * fix comment --------- Signed-off-by: Tiago Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Kube proxy service should not respect HTTP_PROXY env variable and dial kube agent directly.
How
Replace
apimachinerytransport with standardx/net/http2package where HTTP_PROXY envs are not respected.