Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] pass and preserve a path parameter during the app authentication #14053

Merged
merged 8 commits into from
Jul 6, 2022

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Jul 1, 2022

Backport #13832 to branch/v9

@github-actions github-actions bot requested review from Joerger, nklaassen and r0mant July 1, 2022 18:13
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how you generated this backport, but it's usually easiest just to cherry-pick the squashed PR's commit so there's one one commit on the backport branch.

Please squash these commits prior to merge.

@avatus avatus force-pushed the bot/backport-13832-branch/v9 branch from 35039f7 to d48c54e Compare July 3, 2022 03:23
@nklaassen
Copy link
Contributor

Not sure how you generated this backport, but it's usually easiest just to cherry-pick the squashed PR's commit so there's one one commit on the backport branch.

Please squash these commits prior to merge.

@zmb3 fyi when you use "Squash and merge" on the original PR, it seems the backport bot does not use the squashed commit but instead backports each commit. I'm pretty sure the bot to generated this one. Using "Squash and merge" on the backport ultimately has the desired effect, though.

@avatus avatus force-pushed the bot/backport-13832-branch/v9 branch from d48c54e to d9c60ff Compare July 5, 2022 06:39
@avatus avatus force-pushed the bot/backport-13832-branch/v9 branch from d9c60ff to 2ec2ff2 Compare July 5, 2022 22:48
@avatus avatus merged commit 72640a5 into branch/v9 Jul 6, 2022
@zmb3 zmb3 deleted the bot/backport-13832-branch/v9 branch April 26, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants