pass and preserve a path parameter during the app authentication #13832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The webassets submodule update isnt in yet because I want to get feedback on this before I merge the web one just in case this solution doesn't work out. Will push the webassets update before this is merged in |
nklaassen
reviewed
Jun 24, 2022
zmb3
changed the title
|
Most of the meaningful logic is in the client side js returned so I don't really know if we can/should test that, but I did add a test to the app access logic to ensure any expected paths are added in the |
avatus
force-pushed
the
michaelmyers/preserve-app-access-url
branch
from
5a97047 to
317fbab
Compare
nklaassen
reviewed
Jun 29, 2022
nklaassen
reviewed
Jun 29, 2022
nklaassen
approved these changes
Jun 29, 2022
Joerger
approved these changes
Jun 29, 2022
avatus
force-pushed
the
michaelmyers/preserve-app-access-url
branch
5 times, most recently
from
b4f5ad8 to
944c534
Compare
avatus
force-pushed
the
michaelmyers/preserve-app-access-url
branch
from
944c534 to
8bc3ae2
Compare
This was referenced Jul 1, 2022
avatus
added a commit
that referenced
this pull request
Jul 7, 2022
) * pass and preserve a path parameter during the app access authentication process * added missing semicolons * more javascript formatting * removed incorrect path redirect. replace URL with URL.Path * added a test for HasName * added another test for default path * ensure path param is valid path * build url without string concat
avatus
added a commit
that referenced
this pull request
Jul 7, 2022
…#13… (#14205) pass and preserve a path parameter during the app authentication (#13832) * pass and preserve a path parameter during the app access authentication process * added missing semicolons * more javascript formatting * removed incorrect path redirect. replace URL with URL.Path * added a test for HasName * added another test for default path * ensure path param is valid path * build url without string concat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left some detailed info in the webapps PR with some reproduction steps
This would add the requested path as a parameter to the redirect_uri during app access, which would only exist from a bookmarked or shared link since our dashboard links to root anyway. This is where the problem arises, when a path is included in a request but the user is unauthenticated, the requested path is lost during the (many) redirects that happen during the authentication process.
Including this query parameter in the final javascript code in the redirection service will keep the path preserved.
Also, cleaned up the state value params to not be hard coded to retrieve from a specific index and instead uses standard getters with URLSearchParams