Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race on TestFIDO2Login/NOK_cancel_after_PIN #12238

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix race on TestFIDO2Login/NOK_cancel_after_PIN #12238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/auth/webauthncli/fido2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,12 +439,12 @@ func TestFIDO2Login(t *testing.T) {
},
{
name: "NOK cancel after PIN",
fido2: newFakeFIDO2(auth1, pin1),
setUP: pin1.setUP,
prompt: &pinCancelPrompt{pin: pin1.pin}, // cancel set on test body
fido2: newFakeFIDO2(pin3, bio2), // pin3 and bio2 have resident credentials
setUP: pin3.setUP, // user chooses pin3, but cancels before further touches
prompt: &pinCancelPrompt{pin: pin3.pin}, // cancel set on test body
createAssertion: func() *wanlib.CredentialAssertion {
cp := *baseAssertion
cp.Response.AllowedCredentials = nil
cp.Response.AllowedCredentials = nil // passwordless forces PIN
cp.Response.UserVerification = protocol.VerificationRequired
return &cp
},
Expand Down