Fix race on TestFIDO2Login/NOK_cancel_after_PIN #12238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Apr 26, 2022
hatched
approved these changes
Apr 26, 2022
rosstimothy
approved these changes
Apr 26, 2022
codingllama
force-pushed
the
codingllama/fido2login-flaky
branch
from
4e1dc07 to
d151583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rather exoteric race condition where a goroutine beats an already-cancelled context in a select.
The select in question sits on selectDevice / fido2.go#L729. It is not an error for the select to go either way, instead this is a failure of test setup. The fix is simple: we use authenticators that do have resident credentials for the test, so their Assertion operations block waiting for user interaction, eliminating the race in the test in question.
Example flaky execution: https://console.cloud.google.com/cloud-build/builds/ceaa0674-db49-444b-b059-a17e01b0328f?project=ci-account
#9160