Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Edit Database Access guides for Cloud users #11846

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Apr 8, 2022

Backports #11668

  • Edit Database Access guides for Cloud users

This edits Database Access guides that show you how to access
specific databases. These guides follow the same structure and use the
same partials, so it made sense to address them in a single commit.

See #10637

Edits made

  • Some Prerequisites sections were either absent or required
    "Teleport," which I've clarified with a scoped Tabs component to
    indicate the appropriate client tools for each deployment type.
    Since we instruct users on deploying the Auth/Proxy later in the
    guide, I restricted this to client tools. Also flesh out the
    Prerequisites a bit in general.

  • Add ScopedBlocks for minor details that vary between scopes.

  • Ensure that all commands that take place on the Database Service node
    are described correctly as taking place on that node.

  • Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx
    partial now instructs self-hosted users to run tctl commands on the
    Auth Service host, we no longer need the Self-Hosted tab. As a result,
    I have turned the Cloud tab into a ScopedBlock.

  • Reorder self-hosted guide sections so users start the Auth/Proxy
    before running "tctl auth sign". Otherwise, this command will not
    work.

  • Minor style/grammar tweaks

  • Respond to PR feedback

Copy link
Contributor

@ulysseskan ulysseskan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ptgott ptgott enabled auto-merge (squash) April 11, 2022 15:20
@ptgott ptgott force-pushed the paul.gottschling/11668-bp-v9 branch from 4b98e28 to 1adc967 Compare April 11, 2022 15:20
Backports #11668

* Edit Database Access guides for Cloud users

This edits Database Access guides that show you how to access
specific databases. These guides follow the same structure and use the
same partials, so it made sense to address them in a single commit.

See #10637

Edits made

- Some Prerequisites sections were either absent or required
  "Teleport," which I've clarified with a scoped Tabs component to
  indicate the appropriate client tools for each deployment type.
  Since we instruct users on deploying the Auth/Proxy later in the
  guide, I restricted this to client tools. Also flesh out the
  Prerequisites a bit in general.

- Add ScopedBlocks for minor details that vary between scopes.

- Ensure that all commands that take place on the Database Service node
  are described correctly as taking place on that node.

- Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx
  partial now instructs self-hosted users to run tctl commands on the
  Auth Service host, we no longer need the Self-Hosted tab. As a result,
  I have turned the Cloud tab into a ScopedBlock.

- Reorder self-hosted guide sections so users start the Auth/Proxy
  before running "tctl auth sign". Otherwise, this command will not
  work.

- Minor style/grammar tweaks

* Respond to PR feedback
@ptgott ptgott force-pushed the paul.gottschling/11668-bp-v9 branch from 1adc967 to e379afc Compare April 11, 2022 20:39
@ptgott ptgott merged commit 0aa1f52 into branch/v9 Apr 11, 2022
@ptgott ptgott deleted the paul.gottschling/11668-bp-v9 branch April 11, 2022 20:44
@webvictim webvictim mentioned this pull request Apr 19, 2022
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants