-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Database Access guides for Cloud users #11668
Conversation
ecffdc5
to
7e35d83
Compare
See #10637 - Add tabbed instructions in the Prerequisites for users of different scopes. - Add instructions to make it clearer where things are running, since the previous guides did not mention that you need to install and run the Teleport Database Service on a separate host. This adds a new section re: the Database Service that mirrors instructions in other Database Access guides. Note that this branch cherry-picks all docs/pages/includes changes from #11668. Please add feedback on the partials to that branch, and I will keep this branch rebased to that one.
7e35d83
to
a130309
Compare
|
||
</ScopedBlock> | ||
|
||
Fetch short-lived client certificate for your Azure database using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fetch a short-lived client certificate ...
@@ -256,7 +321,7 @@ $ tsh db connect azure-db | |||
|
|||
<Admonition type="note"> | |||
The appropriate database command-line client (`psql`, `mysql`) should be | |||
available in PATH of the machine you're running `tsh db connect` from. | |||
available in `PATH` of the machine you're running `tsh db connect` from. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
available in the PATH
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a couple very minor grammatical suggestions above.
See #10637 - Add tabbed instructions in the Prerequisites for users of different scopes. - Add instructions to make it clearer where things are running, since the previous guides did not mention that you need to install and run the Teleport Database Service on a separate host. This adds a new section re: the Database Service that mirrors instructions in other Database Access guides. Note that this branch cherry-picks all docs/pages/includes changes from #11668. Please add feedback on the partials to that branch, and I will keep this branch rebased to that one.
a130309
to
3f47931
Compare
b52a153
to
f0e9e7b
Compare
This edits Database Access guides that show you how to access specific databases. These guides follow the same structure and use the same partials, so it made sense to address them in a single commit. See #10637 Edits made - Some Prerequisites sections were either absent or required "Teleport," which I've clarified with a scoped Tabs component to indicate the appropriate client tools for each deployment type. Since we instruct users on deploying the Auth/Proxy later in the guide, I restricted this to client tools. Also flesh out the Prerequisites a bit in general. - Add ScopedBlocks for minor details that vary between scopes. - Ensure that all commands that take place on the Database Service node are described correctly as taking place on that node. - Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx partial now instructs self-hosted users to run tctl commands on the Auth Service host, we no longer need the Self-Hosted tab. As a result, I have turned the Cloud tab into a ScopedBlock. - Reorder self-hosted guide sections so users start the Auth/Proxy before running "tctl auth sign". Otherwise, this command will not work. - Minor style/grammar tweaks
f0e9e7b
to
ddeede6
Compare
Also appease the linter.
ddeede6
to
815a886
Compare
Backports #11668 * Edit Database Access guides for Cloud users This edits Database Access guides that show you how to access specific databases. These guides follow the same structure and use the same partials, so it made sense to address them in a single commit. See #10637 Edits made - Some Prerequisites sections were either absent or required "Teleport," which I've clarified with a scoped Tabs component to indicate the appropriate client tools for each deployment type. Since we instruct users on deploying the Auth/Proxy later in the guide, I restricted this to client tools. Also flesh out the Prerequisites a bit in general. - Add ScopedBlocks for minor details that vary between scopes. - Ensure that all commands that take place on the Database Service node are described correctly as taking place on that node. - Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx partial now instructs self-hosted users to run tctl commands on the Auth Service host, we no longer need the Self-Hosted tab. As a result, I have turned the Cloud tab into a ScopedBlock. - Reorder self-hosted guide sections so users start the Auth/Proxy before running "tctl auth sign". Otherwise, this command will not work. - Minor style/grammar tweaks * Respond to PR feedback
Backports #11668 * Edit Database Access guides for Cloud users This edits Database Access guides that show you how to access specific databases. These guides follow the same structure and use the same partials, so it made sense to address them in a single commit. See #10637 Edits made - Some Prerequisites sections were either absent or required "Teleport," which I've clarified with a scoped Tabs component to indicate the appropriate client tools for each deployment type. Since we instruct users on deploying the Auth/Proxy later in the guide, I restricted this to client tools. Also flesh out the Prerequisites a bit in general. - Add ScopedBlocks for minor details that vary between scopes. - Ensure that all commands that take place on the Database Service node are described correctly as taking place on that node. - Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx partial now instructs self-hosted users to run tctl commands on the Auth Service host, we no longer need the Self-Hosted tab. As a result, I have turned the Cloud tab into a ScopedBlock. - Reorder self-hosted guide sections so users start the Auth/Proxy before running "tctl auth sign". Otherwise, this command will not work. - Minor style/grammar tweaks * Respond to PR feedback
Backports #11668 * Edit Database Access guides for Cloud users This edits Database Access guides that show you how to access specific databases. These guides follow the same structure and use the same partials, so it made sense to address them in a single commit. See #10637 Edits made - Some Prerequisites sections were either absent or required "Teleport," which I've clarified with a scoped Tabs component to indicate the appropriate client tools for each deployment type. Since we instruct users on deploying the Auth/Proxy later in the guide, I restricted this to client tools. Also flesh out the Prerequisites a bit in general. - Add ScopedBlocks for minor details that vary between scopes. - Ensure that all commands that take place on the Database Service node are described correctly as taking place on that node. - Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx partial now instructs self-hosted users to run tctl commands on the Auth Service host, we no longer need the Self-Hosted tab. As a result, I have turned the Cloud tab into a ScopedBlock. - Reorder self-hosted guide sections so users start the Auth/Proxy before running "tctl auth sign". Otherwise, this command will not work. - Minor style/grammar tweaks * Respond to PR feedback
See #10637 - Add tabbed instructions in the Prerequisites for users of different scopes. - Add instructions to make it clearer where things are running, since the previous guides did not mention that you need to install and run the Teleport Database Service on a separate host. This adds a new section re: the Database Service that mirrors instructions in other Database Access guides. Note that this branch cherry-picks all docs/pages/includes changes from #11668. Please add feedback on the partials to that branch, and I will keep this branch rebased to that one.
* Edit Redis guides for Cloud users See #10637 - Add tabbed instructions in the Prerequisites for users of different scopes. - Add instructions to make it clearer where things are running, since the previous guides did not mention that you need to install and run the Teleport Database Service on a separate host. This adds a new section re: the Database Service that mirrors instructions in other Database Access guides. Note that this branch cherry-picks all docs/pages/includes changes from #11668. Please add feedback on the partials to that branch, and I will keep this branch rebased to that one. * Address PR feedback
This edits Database Access guides that show you how to access
specific databases. These guides follow the same structure and use the
same partials, so it made sense to address them in a single commit.
See #10637
Edits made
Some Prerequisites sections were either absent or required
"Teleport," which I've clarified with a scoped Tabs component to
indicate the appropriate client tools for each deployment type.
Since we instruct users on deploying the Auth/Proxy later in the
guide, I restricted this to client tools. Also flesh out the
Prerequisites a bit in general.
Add ScopedBlocks for minor details that vary between scopes.
Ensure that all commands that take place on the Database Service node
are described correctly as taking place on that node.
Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx
partial now instructs self-hosted users to run tctl commands on the
Auth Service host, we no longer need the Self-Hosted tab. As a result,
I have turned the Cloud tab into a ScopedBlock.
Reorder self-hosted guide sections so users start the Auth/Proxy
before running "tctl auth sign". Otherwise, this command will not
work.
Minor style/grammar tweaks