Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Database Access guides for Cloud users #11668

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Apr 1, 2022

This edits Database Access guides that show you how to access
specific databases. These guides follow the same structure and use the
same partials, so it made sense to address them in a single commit.

See #10637

Edits made

  • Some Prerequisites sections were either absent or required
    "Teleport," which I've clarified with a scoped Tabs component to
    indicate the appropriate client tools for each deployment type.
    Since we instruct users on deploying the Auth/Proxy later in the
    guide, I restricted this to client tools. Also flesh out the
    Prerequisites a bit in general.

  • Add ScopedBlocks for minor details that vary between scopes.

  • Ensure that all commands that take place on the Database Service node
    are described correctly as taking place on that node.

  • Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx
    partial now instructs self-hosted users to run tctl commands on the
    Auth Service host, we no longer need the Self-Hosted tab. As a result,
    I have turned the Cloud tab into a ScopedBlock.

  • Reorder self-hosted guide sections so users start the Auth/Proxy
    before running "tctl auth sign". Otherwise, this command will not
    work.

  • Minor style/grammar tweaks

@ptgott ptgott force-pushed the paul.gottschling/10637-2 branch from ecffdc5 to 7e35d83 Compare April 4, 2022 13:55
ptgott added a commit that referenced this pull request Apr 5, 2022
See #10637

- Add tabbed instructions in the Prerequisites for users of
  different scopes.

- Add instructions to make it clearer where things are running, since
  the previous guides did not mention that you need to install and
  run the Teleport Database Service on a separate host. This adds
  a new section re: the Database Service that mirrors instructions
  in other Database Access guides.

Note that this branch cherry-picks all docs/pages/includes changes
from #11668. Please add feedback on the partials to that branch,
and I will keep this branch rebased to that one.
@ptgott ptgott force-pushed the paul.gottschling/10637-2 branch from 7e35d83 to a130309 Compare April 5, 2022 19:17

</ScopedBlock>

Fetch short-lived client certificate for your Azure database using the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetch a short-lived client certificate ...

@@ -256,7 +321,7 @@ $ tsh db connect azure-db

<Admonition type="note">
The appropriate database command-line client (`psql`, `mysql`) should be
available in PATH of the machine you're running `tsh db connect` from.
available in `PATH` of the machine you're running `tsh db connect` from.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

available in the PATH ...

Copy link
Contributor

@ulysseskan ulysseskan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple very minor grammatical suggestions above.

ptgott added a commit that referenced this pull request Apr 7, 2022
See #10637

- Add tabbed instructions in the Prerequisites for users of
  different scopes.

- Add instructions to make it clearer where things are running, since
  the previous guides did not mention that you need to install and
  run the Teleport Database Service on a separate host. This adds
  a new section re: the Database Service that mirrors instructions
  in other Database Access guides.

Note that this branch cherry-picks all docs/pages/includes changes
from #11668. Please add feedback on the partials to that branch,
and I will keep this branch rebased to that one.
@ptgott ptgott force-pushed the paul.gottschling/10637-2 branch from a130309 to 3f47931 Compare April 7, 2022 20:13
@ptgott ptgott enabled auto-merge (squash) April 7, 2022 20:18
@ptgott ptgott force-pushed the paul.gottschling/10637-2 branch from b52a153 to f0e9e7b Compare April 7, 2022 20:49
This edits Database Access guides that show you how to access
specific databases. These guides follow the same structure and use the
same partials, so it made sense to address them in a single commit.

See #10637

Edits made

- Some Prerequisites sections were either absent or required
  "Teleport," which I've clarified with a scoped Tabs component to
  indicate the appropriate client tools for each deployment type.
  Since we instruct users on deploying the Auth/Proxy later in the
  guide, I restricted this to client tools. Also flesh out the
  Prerequisites a bit in general.

- Add ScopedBlocks for minor details that vary between scopes.

- Ensure that all commands that take place on the Database Service node
  are described correctly as taking place on that node.

- Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx
  partial now instructs self-hosted users to run tctl commands on the
  Auth Service host, we no longer need the Self-Hosted tab. As a result,
  I have turned the Cloud tab into a ScopedBlock.

- Reorder self-hosted guide sections so users start the Auth/Proxy
  before running "tctl auth sign". Otherwise, this command will not
  work.

- Minor style/grammar tweaks
@ptgott ptgott force-pushed the paul.gottschling/10637-2 branch from f0e9e7b to ddeede6 Compare April 8, 2022 19:28
Also appease the linter.
@ptgott ptgott force-pushed the paul.gottschling/10637-2 branch from ddeede6 to 815a886 Compare April 8, 2022 19:42
@ptgott ptgott merged commit 7ef1e05 into master Apr 8, 2022
@ptgott ptgott deleted the paul.gottschling/10637-2 branch April 8, 2022 19:46
ptgott added a commit that referenced this pull request Apr 8, 2022
Backports #11668

* Edit Database Access guides for Cloud users

This edits Database Access guides that show you how to access
specific databases. These guides follow the same structure and use the
same partials, so it made sense to address them in a single commit.

See #10637

Edits made

- Some Prerequisites sections were either absent or required
  "Teleport," which I've clarified with a scoped Tabs component to
  indicate the appropriate client tools for each deployment type.
  Since we instruct users on deploying the Auth/Proxy later in the
  guide, I restricted this to client tools. Also flesh out the
  Prerequisites a bit in general.

- Add ScopedBlocks for minor details that vary between scopes.

- Ensure that all commands that take place on the Database Service node
  are described correctly as taking place on that node.

- Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx
  partial now instructs self-hosted users to run tctl commands on the
  Auth Service host, we no longer need the Self-Hosted tab. As a result,
  I have turned the Cloud tab into a ScopedBlock.

- Reorder self-hosted guide sections so users start the Auth/Proxy
  before running "tctl auth sign". Otherwise, this command will not
  work.

- Minor style/grammar tweaks

* Respond to PR feedback
ptgott added a commit that referenced this pull request Apr 11, 2022
Backports #11668

* Edit Database Access guides for Cloud users

This edits Database Access guides that show you how to access
specific databases. These guides follow the same structure and use the
same partials, so it made sense to address them in a single commit.

See #10637

Edits made

- Some Prerequisites sections were either absent or required
  "Teleport," which I've clarified with a scoped Tabs component to
  indicate the appropriate client tools for each deployment type.
  Since we instruct users on deploying the Auth/Proxy later in the
  guide, I restricted this to client tools. Also flesh out the
  Prerequisites a bit in general.

- Add ScopedBlocks for minor details that vary between scopes.

- Ensure that all commands that take place on the Database Service node
  are described correctly as taking place on that node.

- Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx
  partial now instructs self-hosted users to run tctl commands on the
  Auth Service host, we no longer need the Self-Hosted tab. As a result,
  I have turned the Cloud tab into a ScopedBlock.

- Reorder self-hosted guide sections so users start the Auth/Proxy
  before running "tctl auth sign". Otherwise, this command will not
  work.

- Minor style/grammar tweaks

* Respond to PR feedback
ptgott added a commit that referenced this pull request Apr 11, 2022
Backports #11668

* Edit Database Access guides for Cloud users

This edits Database Access guides that show you how to access
specific databases. These guides follow the same structure and use the
same partials, so it made sense to address them in a single commit.

See #10637

Edits made

- Some Prerequisites sections were either absent or required
  "Teleport," which I've clarified with a scoped Tabs component to
  indicate the appropriate client tools for each deployment type.
  Since we instruct users on deploying the Auth/Proxy later in the
  guide, I restricted this to client tools. Also flesh out the
  Prerequisites a bit in general.

- Add ScopedBlocks for minor details that vary between scopes.

- Ensure that all commands that take place on the Database Service node
  are described correctly as taking place on that node.

- Change the tctl-auth-sign.mdx partial. Since the start-auth-proxy.mdx
  partial now instructs self-hosted users to run tctl commands on the
  Auth Service host, we no longer need the Self-Hosted tab. As a result,
  I have turned the Cloud tab into a ScopedBlock.

- Reorder self-hosted guide sections so users start the Auth/Proxy
  before running "tctl auth sign". Otherwise, this command will not
  work.

- Minor style/grammar tweaks

* Respond to PR feedback
ptgott added a commit that referenced this pull request Apr 13, 2022
See #10637

- Add tabbed instructions in the Prerequisites for users of
  different scopes.

- Add instructions to make it clearer where things are running, since
  the previous guides did not mention that you need to install and
  run the Teleport Database Service on a separate host. This adds
  a new section re: the Database Service that mirrors instructions
  in other Database Access guides.

Note that this branch cherry-picks all docs/pages/includes changes
from #11668. Please add feedback on the partials to that branch,
and I will keep this branch rebased to that one.
ptgott added a commit that referenced this pull request Apr 13, 2022
* Edit Redis guides for Cloud users

See #10637

- Add tabbed instructions in the Prerequisites for users of
  different scopes.

- Add instructions to make it clearer where things are running, since
  the previous guides did not mention that you need to install and
  run the Teleport Database Service on a separate host. This adds
  a new section re: the Database Service that mirrors instructions
  in other Database Access guides.

Note that this branch cherry-picks all docs/pages/includes changes
from #11668. Please add feedback on the partials to that branch,
and I will keep this branch rebased to that one.

* Address PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants