Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport SQL Backend to v9 #11667

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Backport SQL Backend to v9 #11667

merged 2 commits into from
Apr 6, 2022

Conversation

jimbishopp
Copy link
Contributor

This PR backports the SQL Backend to branch v9. It includes commits from the following master branch PRs.

@github-actions github-actions bot added the database-access Database access related issues and PRs label Apr 1, 2022
@jimbishopp jimbishopp self-assigned this Apr 1, 2022
@jimbishopp jimbishopp enabled auto-merge (squash) April 1, 2022 15:24
Tener
Tener approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@Tener Tener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plans to update the docs, e.g. /docs/pages/setup/reference/backends.mdx?

@jimbishopp
Remove migration from backend API (#10835)
bee4256 
The Migrate method on the Backend interface was not implemented by any
backends.

Migration should be implemented in the New method of backends so they
can be sure migration happens before any background processes are
started.
@jimbishopp
Backport SQL Backend to v9
c6e727d 
Original PR: #11048

Add a new backend supporting PostgreSQL and CockroachDB.

Implements #10253 without cloud connectivity.
@jimbishopp jimbishopp merged commit 142ea07 into branch/v9 Apr 6, 2022
@jimbishopp jimbishopp deleted the jim/v9/sqlbk branch April 6, 2022 13:59
@jimbishopp
Copy link
Contributor Author

@Tener Yes, we need to update the docs to indicate this is being released as a preview.

@webvictim webvictim mentioned this pull request Apr 19, 2022
Closed
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smallinsky smallinsky smallinsky approved these changes

@r0mant r0mant r0mant approved these changes

@Tener Tener Tener approved these changes

@fspmarshall fspmarshall Awaiting requested review from fspmarshall

Assignees

@jimbishopp jimbishopp

Labels
database-access Database access related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimbishopp @Tener @r0mant @smallinsky